rfscholte commented on code in PR #13956: URL: https://github.com/apache/pinot/pull/13956#discussion_r1771816878
########## pinot-connectors/pinot-spark-2-connector/pom.xml: ########## @@ -35,6 +35,45 @@ </properties> <profiles> + <profile> + <id>build-shaded-jar</id> + <activation> Review Comment: I think you want to use `active-profiles` here, see https://maven.apache.org/guides/introduction/introduction-to-profiles.html ########## pom.xml: ########## @@ -293,6 +293,7 @@ <!-- This plugin slows down the builds, most likely caused by an issue in the deprecated org.apache.maven.shared.utils.io.DirectoryScanner --> <rat.skip>true</rat.skip> <spotless.check.skip>true</spotless.check.skip> + <shade.phase.prop>none</shade.phase.prop> Review Comment: Why didn't you put the property shade.phase.prop in the one-and-only pinot-fastdev profile? it doesn't really matter if that proeprty is not used, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
