ankitsultana commented on code in PR #14048:
URL: https://github.com/apache/pinot/pull/14048#discussion_r1772533406
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/dispatch/QueryDispatcher.java:
##########
@@ -245,6 +323,14 @@ private DispatchClient
getOrCreateDispatchClient(QueryServerInstance queryServer
return _dispatchClientMap.computeIfAbsent(key, k -> new
DispatchClient(hostname, port));
}
+ private TimeSeriesDispatchClient getOrCreateTimeSeriesDispatchClient(
+ TimeSeriesQueryServerInstance queryServerInstance) {
+ String hostname = queryServerInstance.getHostname();
+ int port = queryServerInstance.getQueryServicePort();
+ String key = String.format("%s_%d", hostname, port);
Review Comment:
This is the same as the Multistage Engine so all related constraints will
apply. In case of a hostname change, that will involve a node restart which
will anyways lead to a query failure. Right now our Multistage queries aren't
able to still run if any of the involved server dies or gets restarted midway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
