gortiz commented on code in PR #13956: URL: https://github.com/apache/pinot/pull/13956#discussion_r1771393553
########## pinot-connectors/pinot-spark-2-connector/pom.xml: ########## @@ -35,6 +35,45 @@ </properties> <profiles> + <profile> + <id>build-shaded-jar</id> + <activation> + <activeByDefault>true</activeByDefault> + </activation> + <build> + <plugins> + <plugin> + <artifactId>maven-shade-plugin</artifactId> Review Comment: Previously the plugin was configured in the scala 2.12 profile, which I think it is incorrect. Specifically in master when using scala 2.13 some packages are not be shaded (or not in the same way). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
