gortiz commented on code in PR #12343:
URL: https://github.com/apache/pinot/pull/12343#discussion_r1473921998
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1127,6 +1127,7 @@ private void closePartitionMetadataProv
gortiz commented on code in PR #12343:
URL: https://github.com/apache/pinot/pull/12343#discussion_r1473910243
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1127,6 +1127,7 @@ private void closePartitionMetadataProv
gortiz commented on code in PR #12343:
URL: https://github.com/apache/pinot/pull/12343#discussion_r1473906900
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1127,6 +1127,7 @@ private void closePartitionMetadataProv
gortiz commented on PR #12343:
URL: https://github.com/apache/pinot/pull/12343#issuecomment-1920659084
> When segment is dropped from server (due to rebalance or segment removal),
TableDataManager.onConsumingToDropped() will be invoked via the helix state
transition from CONSUMING to DROPPE
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch
maintain-pool-selection-for-minimizeDataMovement
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit a286bd868f434c72e32351890566d684ec14a378
Author: Xiaotian (Jackie) Jiang
Autho
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
maintain-pool-selection-for-minimizeDataMovement
in repository https://gitbox.apache.org/repos/asf/pinot.git
omit 08efc8c2f1 Add logic to consider the case when instances are moved
across p
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch
maintain-pool-selection-for-minimizeDataMovement
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 9550545be3ea35b2874d79a62d396806c0f0f23f
Author: jlli_LinkedIn
AuthorDate: Sun
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch
maintain-pool-selection-for-minimizeDataMovement
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 25b4c3a212b234106a92e30489b03f195d3eb60c
Author: jlli_LinkedIn
AuthorDate: Fri
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch
maintain-pool-selection-for-minimizeDataMovement
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 97ab0b7d4599fba3b85129982ed7132eeaf9ecf0
Author: Jialiang Li
AuthorDate: Tue N
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch
maintain-pool-selection-for-minimizeDataMovement
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 2a934ef00dcccb74a60312309300fcdbd013dd92
Author: jlli_LinkedIn
AuthorDate: Thu
jackjlli commented on PR #12297:
URL: https://github.com/apache/pinot/pull/12297#issuecomment-1920640184
Comments have been addressed in the latest push and the description is
updated. Please take a look. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to t
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch stop-all-segments-in-releaseAndRemoveAllSegments
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard 2abd892fe1 Release all segments of a table in
releaseAndRemoveAllSegments meth
vrajat commented on code in PR #12157:
URL: https://github.com/apache/pinot/pull/12157#discussion_r1473771585
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -140,6 +142,8 @@ public class PinotLLCRealti
vrajat commented on code in PR #12157:
URL: https://github.com/apache/pinot/pull/12157#discussion_r1473780835
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1648,6 +1648,15 @@ private void makeStreamConsumer(String
vrajat commented on code in PR #12157:
URL: https://github.com/apache/pinot/pull/12157#discussion_r1473780427
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1648,6 +1648,15 @@ private void makeStreamConsumer(String
vrajat commented on code in PR #12157:
URL: https://github.com/apache/pinot/pull/12157#discussion_r1473773112
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -1711,4 +1725,14 @@ String moveSegmentFile(S
vrajat commented on code in PR #12157:
URL: https://github.com/apache/pinot/pull/12157#discussion_r1473772323
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -1711,4 +1725,14 @@ String moveSegmentFile(S
vrajat commented on code in PR #12157:
URL: https://github.com/apache/pinot/pull/12157#discussion_r1473771585
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -140,6 +142,8 @@ public class PinotLLCRealti
vrajat commented on code in PR #12157:
URL: https://github.com/apache/pinot/pull/12157#discussion_r1473761868
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -889,6 +892,39 @@ public Map
getPartitionToLagState(
vrajat commented on code in PR #12157:
URL: https://github.com/apache/pinot/pull/12157#discussion_r1473760338
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -1339,7 +1346,14 @@ private StreamPartitionM
vrajat commented on code in PR #12157:
URL: https://github.com/apache/pinot/pull/12157#discussion_r1473759897
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -889,6 +892,39 @@ public Map
getPartitionToLagState(
vrajat commented on code in PR #12157:
URL: https://github.com/apache/pinot/pull/12157#discussion_r1473755477
##
pinot-tools/src/main/java/org/apache/pinot/tools/RealTimeSlowConsumer.java:
##
@@ -0,0 +1,142 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+
jackjlli opened a new pull request, #12347:
URL: https://github.com/apache/pinot/pull/12347
This PR fixes a backward incompatible issue introduced by this PR:
https://github.com/apache/pinot/pull/12042
Printed stacktrace from the broker log:
```
Caused by: java.lang.ClassCastExc
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch fix-DistinctCountThetaSketchAggregationFunction
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 577e5e2c58c26fa16ac7a692c0741ed47033cc63
Author: jlli_LinkedIn
AuthorDate: Wed Jan
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch fix-DistinctCountThetaSketchAggregationFunction
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 577e5e2c58 Fix backward compatible issue in
DistinctCountThetaSketchAggregation
lnbest0707-uber commented on PR #12336:
URL: https://github.com/apache/pinot/pull/12336#issuecomment-1920166282
> the approach looks good. i was wondering if we should have some
definitions. e.g. when nReplica equals the following, how should we call each
status. HighAvailability is not a v
lnbest0707-uber closed pull request #12336: Add metrics for no-HA segments
monitoring
URL: https://github.com/apache/pinot/pull/12336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
lnbest0707-uber commented on PR #12336:
URL: https://github.com/apache/pinot/pull/12336#issuecomment-1920154349
> the approach looks good. i was wondering if we should have some
definitions. e.g. when nReplica equals the following, how should we call each
status. HighAvailability is not a v
walterddr commented on code in PR #12338:
URL: https://github.com/apache/pinot/pull/12338#discussion_r1473591396
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java:
##
@@ -348,4 +349,25 @@ private static HttpRequesterIdentity
makeHttpIde
walterddr commented on code in PR #12336:
URL: https://github.com/apache/pinot/pull/12336#discussion_r1473582032
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java:
##
@@ -311,6 +312,9 @@ private void updateSegmentMetrics(String tableNa
Jackie-Jiang commented on code in PR #12346:
URL: https://github.com/apache/pinot/pull/12346#discussion_r1473577054
##
pinot-common/src/main/java/org/apache/pinot/common/restlet/resources/ValidDocIdMetadataInfo.java:
##
@@ -28,14 +28,16 @@ public class ValidDocIdMetadataInfo {
snleee commented on code in PR #12343:
URL: https://github.com/apache/pinot/pull/12343#discussion_r1473573645
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1127,6 +1127,7 @@ private void closePartitionMetadataProv
snleee commented on code in PR #12343:
URL: https://github.com/apache/pinot/pull/12343#discussion_r1473573645
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1127,6 +1127,7 @@ private void closePartitionMetadataProv
Jackie-Jiang commented on code in PR #12345:
URL: https://github.com/apache/pinot/pull/12345#discussion_r1473572509
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/periodictask/ControllerPeriodicTask.java:
##
@@ -63,29 +69,25 @@ protected final void runT
Jackie-Jiang commented on PR #12343:
URL: https://github.com/apache/pinot/pull/12343#issuecomment-1920104240
When segment is dropped from server (due to rebalance or segment removal),
`TableDataManager.onConsumingToDropped()` will be invoked via the helix state
transition from `CONSUMING` t
jackjlli commented on PR #12297:
URL: https://github.com/apache/pinot/pull/12297#issuecomment-1920073524
> If the intention is to accelerate the server shutdown, we can consider
parallel the table data manager shutdown in
HelixInstanceDataManager.shutDown(), at which moment we know server i
codecov-commenter commented on PR #12346:
URL: https://github.com/apache/pinot/pull/12346#issuecomment-1920066705
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12346?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
Jackie-Jiang commented on code in PR #12297:
URL: https://github.com/apache/pinot/pull/12297#discussion_r1473524770
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -223,8 +224,21 @@ protected void releaseAndRemoveAllSegments() {
walterddr commented on code in PR #12326:
URL: https://github.com/apache/pinot/pull/12326#discussion_r1473518923
##
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotResultSet.java:
##
@@ -193,13 +193,19 @@ public InputStream getAsciiStream(int columnInd
gortiz commented on code in PR #12343:
URL: https://github.com/apache/pinot/pull/12343#discussion_r1473517797
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1127,6 +1127,7 @@ private void closePartitionMetadataProv
BrendanStans21 commented on code in PR #12326:
URL: https://github.com/apache/pinot/pull/12326#discussion_r1473514046
##
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotResultSet.java:
##
@@ -193,13 +193,19 @@ public InputStream getAsciiStream(int colu
This is an automated email from the ASF dual-hosted git repository.
tingchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 17db0fd17b add ScalingThreadPoolExecutor and us
chenboat merged PR #12274:
URL: https://github.com/apache/pinot/pull/12274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
This is an automated email from the ASF dual-hosted git repository.
tingchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new dd8be2a229 add TextMatchFilterOptimizer to maxi
chenboat merged PR #12339:
URL: https://github.com/apache/pinot/pull/12339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
snleee opened a new pull request, #12346:
URL: https://github.com/apache/pinot/pull/12346
The current code can face the race condition when the following condition is
met:
1. Segment upload is complete for segment replacement and segment zk
metadata is changed to point the new segmen
walterddr commented on code in PR #12332:
URL: https://github.com/apache/pinot/pull/12332#discussion_r1473462577
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java:
##
@@ -85,8 +85,9 @@ public JsonAsyncHttpPinot
walterddr commented on code in PR #12332:
URL: https://github.com/apache/pinot/pull/12332#discussion_r1473458810
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java:
##
@@ -85,8 +85,9 @@ public JsonAsyncHttpPinot
walterddr commented on code in PR #12332:
URL: https://github.com/apache/pinot/pull/12332#discussion_r1473458505
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java:
##
@@ -85,8 +85,9 @@ public JsonAsyncHttpPinot
walterddr commented on code in PR #12332:
URL: https://github.com/apache/pinot/pull/12332#discussion_r1473458505
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransportFactory.java:
##
@@ -85,8 +85,9 @@ public JsonAsyncHttpPinot
walterddr commented on code in PR #12326:
URL: https://github.com/apache/pinot/pull/12326#discussion_r1473456422
##
pinot-clients/pinot-jdbc-client/src/main/java/org/apache/pinot/client/PinotResultSet.java:
##
@@ -193,13 +193,19 @@ public InputStream getAsciiStream(int columnInd
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 8988b755d6 Remove segments with empty download url
walterddr merged PR #12320:
URL: https://github.com/apache/pinot/pull/12320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
codecov-commenter commented on PR #12336:
URL: https://github.com/apache/pinot/pull/12336#issuecomment-1919783914
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12336?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
zhtaoxiang commented on code in PR #12343:
URL: https://github.com/apache/pinot/pull/12343#discussion_r1473326112
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1127,6 +1127,7 @@ private void closePartitionMetadata
codecov-commenter commented on PR #12345:
URL: https://github.com/apache/pinot/pull/12345#issuecomment-1919459131
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12345?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
gortiz commented on PR #12345:
URL: https://github.com/apache/pinot/pull/12345#issuecomment-1919388045
cc @suddendust @zhtaoxiang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
gortiz opened a new pull request, #12345:
URL: https://github.com/apache/pinot/pull/12345
Labels:
* `bugfix`
* `observability`
This PR removes a bunch of metrics that should be removed when segments are
deleted.
See #12344
--
This is an automated message from the Apac
gortiz opened a new issue, #12344:
URL: https://github.com/apache/pinot/issues/12344
It has been detected that some table metrics are not removed when a table is
deleted. Due to the variable nature of the metrics, which are lazily
registered, it is difficult to create a complete list of the
gortiz commented on code in PR #12343:
URL: https://github.com/apache/pinot/pull/12343#discussion_r1472744360
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -1127,6 +1127,7 @@ private void closePartitionMetadataProv
codecov-commenter commented on PR #12343:
URL: https://github.com/apache/pinot/pull/12343#issuecomment-1918993992
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12343?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
gortiz opened a new pull request, #12343:
URL: https://github.com/apache/pinot/pull/12343
Labels:
* `bugfix`
* `observability`
Metric `realtimeIngestionDelayMs` were not deleted on rebalance. For example
imagina a cluster with two servers where 5 partitions are in server 0 and 5
tibrewalpratik17 commented on PR #12320:
URL: https://github.com/apache/pinot/pull/12320#issuecomment-1918848339
@walterddr can you help approve / merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from d5014786db Add first implementation of clpMatch that doesn't
explicitly use indexes. (#12291)
add 3ab28348fb aut
64 matches
Mail list logo
