zhtaoxiang commented on code in PR #12343:
URL: https://github.com/apache/pinot/pull/12343#discussion_r1473326112
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1127,6 +1127,7 @@ private void closePartitionMetadataProvider() {
*/
private void cleanupMetrics() {
_serverMetrics.removeTableGauge(_clientId,
ServerGauge.LLC_PARTITION_CONSUMING);
+ _realtimeTableDataManager.onConsumingToDropped(_segmentNameStr);
Review Comment:
Thanks for fixing this.
One corner case I can think of: if the creation of a new consuming segment
gets stuck, then we miss both metrics. For LLC_PARTITION_CONSUMING, we use it
to check if consuming is stopped or not, it is expected to miss it. The
question is: do we want to stop emitting ingestion delay metric in this case?
Is this a valid concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
