(pinot) branch master updated: Remove segments with empty download url in UpsertCompactionTask (#12320)

[rongr]

This is an automated email from the ASF dual-hosted git repository.

rongr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 8988b755d6 Remove segments with empty download url in 
UpsertCompactionTask (#12320)
8988b755d6 is described below

commit 8988b755d6011aacd430b208a55bd5db1e17df6c
Author: Pratik Tibrewal <tibrewalpra...@uber.com>
AuthorDate: Thu Feb 1 02:24:21 2024 +0530

    Remove segments with empty download url in UpsertCompactionTask (#12320)
    
    * Remove segments with empty download url in minion-tasks
---
 .../minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java | 5 +++++
 1 file changed, 5 insertions(+)

diff --git 
a/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java
 
b/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java
index 210e892434..188d90606b 100644
--- 
a/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java
+++ 
b/pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/upsertcompaction/UpsertCompactionTaskGenerator.java
@@ -26,6 +26,7 @@ import java.util.List;
 import java.util.Map;
 import java.util.function.Function;
 import java.util.stream.Collectors;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.helix.task.TaskState;
 import org.apache.pinot.common.exception.InvalidConfigException;
 import org.apache.pinot.common.metadata.segment.SegmentZKMetadata;
@@ -146,6 +147,10 @@ public class UpsertCompactionTaskGenerator extends 
BaseTaskGenerator {
         if (numTasks == maxTasks) {
           break;
         }
+        if (StringUtils.isBlank(segment.getDownloadUrl())) {
+          LOGGER.warn("Skipping segment {} for task {} as download url is 
empty", segment.getSegmentName(), taskType);
+          continue;
+        }
         Map<String, String> configs = new HashMap<>();
         configs.put(MinionConstants.TABLE_NAME_KEY, tableNameWithType);
         configs.put(MinionConstants.SEGMENT_NAME_KEY, 
segment.getSegmentName());


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org