vrajat commented on code in PR #12157:
URL: https://github.com/apache/pinot/pull/12157#discussion_r1473760338
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1339,7 +1346,14 @@ private StreamPartitionMsgOffset
selectStartOffset(OffsetCriteria offsetCriteria
LOGGER.error("Data lost from offset: {} to: {} for partition: {} of
table: {}", startOffsetInSegmentZkMetadata,
streamSmallestOffset, partitionGroupId, tableName);
_controllerMetrics.addMeteredTableValue(tableName,
ControllerMeter.LLC_STREAM_DATA_LOSS, 1L);
- return streamSmallestOffset;
+ String message = "Data lost from offset: " +
startOffsetInSegmentZkMetadata
+ + " to: " + streamSmallestOffset
+ + " for partition: " + partitionGroupId
+ + " of table: " + tableName;
+
+ _errorCache.put(Pair.of(tableName, segmentName),
+ new SegmentErrorInfo(String.valueOf(System.currentTimeMillis()),
message, ""));
Review Comment:
Made this change locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
