gortiz commented on code in PR #12343:
URL: https://github.com/apache/pinot/pull/12343#discussion_r1473906900
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1127,6 +1127,7 @@ private void closePartitionMetadataProvider() {
*/
private void cleanupMetrics() {
_serverMetrics.removeTableGauge(_clientId,
ServerGauge.LLC_PARTITION_CONSUMING);
+ _realtimeTableDataManager.onConsumingToDropped(_segmentNameStr);
Review Comment:
Given we have some reticence on merging this change, I've been thinking we
could solve our current false alert problem by multiplying
REALTIME_INGESTION_DELAY_MS by LLC_PARTITION_CONSUMING (which is either 0 or 1).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
