gortiz commented on code in PR #12343:
URL: https://github.com/apache/pinot/pull/12343#discussion_r1473921998
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1127,6 +1127,7 @@ private void closePartitionMetadataProvider() {
*/
private void cleanupMetrics() {
_serverMetrics.removeTableGauge(_clientId,
ServerGauge.LLC_PARTITION_CONSUMING);
+ _realtimeTableDataManager.onConsumingToDropped(_segmentNameStr);
Review Comment:
> @gortiz are we handling no metrics properly? (i.e. if there's no metric,
we should treat it as 0 on the alerting system?)
We are using Prometheus. In Prometheus 0 is different than non existent.
When a metric is not existent, the expression evaluates to no value. That is
consistent for example to what happens when a table is deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
