jackjlli commented on PR #12297: URL: https://github.com/apache/pinot/pull/12297#issuecomment-1920073524
> If the intention is to accelerate the server shutdown, we can consider parallel the table data manager shutdown in HelixInstanceDataManager.shutDown(), at which moment we know server is not serving queries. Yes, the intention is to accelerate the server shutdown. Paralleling table data manager shutdown can help in one way, whereas there is another scenario that there is some certain table with too many segments which require to be shut down one by one (and unfortunately this is the scenario we met). I can add the parallelism to the table level shutdown as well as changing the thread pool to a fixed sized thread pool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
