Jackie-Jiang commented on PR #12343: URL: https://github.com/apache/pinot/pull/12343#issuecomment-1920104240
When segment is dropped from server (due to rebalance or segment removal), `TableDataManager.onConsumingToDropped()` will be invoked via the helix state transition from `CONSUMING` to `DROPPED`. IMO the real problem is the ordering of invoking this callback and offloading the segment. Currently we invoke the callback then offload the segment, where the metric might be updated again after it is dropped. I think we can fix it by moving the callback into a finally block which happens after offloading and deleting the segment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
