gortiz commented on code in PR #12343:
URL: https://github.com/apache/pinot/pull/12343#discussion_r1473517797
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -1127,6 +1127,7 @@ private void closePartitionMetadataProvider() {
*/
private void cleanupMetrics() {
_serverMetrics.removeTableGauge(_clientId,
ServerGauge.LLC_PARTITION_CONSUMING);
+ _realtimeTableDataManager.onConsumingToDropped(_segmentNameStr);
Review Comment:
The logic of the ingestion alert should be to be fired when:
```
For any partition
- sum LLC_PARTITION_CONSUMING by server = 0
- max(REALTIME_INGESTION_DELAY_MS) is higher than a value
```
In case the ingestion gets stuck after calling `cleanupMetrics` the first
condition should be true and therefore the alert should be fired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
