Re: Review Request 108861: Improved Table handling for the HTML export filter

/OdtHtmlConverter.cpp <http://git.reviewboard.kde.org/r/108861/#comment20355> a bit risky if both AB and A.B exists in the odf - C. Boemann On Feb. 8, 2013, 4:34 p.m., Arjen Hiemstra wrote: > > --- > This is a

Re: Review Request 108868: fix KoTextWriter::saveParagraph(...) to not crash on QTextDocuments without a KoTextRangeManager

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108868/#review27002 --- Ship it! Ship It! - C. Boemann On Feb. 8, 2013, 8:57 p.m

Re: Review Request 108865: First step in a cleanup of all border handling

i believe it to be all ranom cstester issues) so good work! - C. Boemann On Feb. 8, 2013, 7:38 p.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 108882: Port ReviewTool to using TextTool as the baseclass as opposed to KoToolBase

shown plugins/textshape/ReviewTool.cpp <http://git.reviewboard.kde.org/r/108882/#comment20441> removing copyrights is wrong. - C. Boemann On Feb. 10, 2013, 1:13 a.m., Luke De Mouy wrote: > > --- > This is an automatically

Re: next release and release pace in general

On Sunday 10 February 2013 11:50:26 Cyrille Berger Skott wrote: > Now that I have said that. I guess the current problem is that the current > policy for releases is to have four months between "branching". Instead, we > could replace that policy by four months between the last major .0 release > a

Re: Review Request 108781: Moving Formatting in Calligrawords from old framework to new framework.

imilar to how it's fixed in setStyle(KoCharacterStyle - C. Boemann On Feb. 5, 2013, 3:29 p.m., Sudhendu Kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revie

Re: Review Request 108861: Improved Table handling for the HTML export filter

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108861/#review27200 --- Ship it! Ship It! - C. Boemann On Feb. 11, 2013, 1:27 p.m

Re: Review Request 108781: Moving Formatting in Calligrawords from old framework to new framework.

<http://git.reviewboard.kde.org/r/108781/#comment20498> oops i don't think you mean to change this - C. Boemann On Feb. 11, 2013, 6:52 p.m., Sudhendu Kumar wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 108923: added some more autocorrections in autocorrect.xml and en_US.xml

<http://git.reviewboard.kde.org/r/108923/#comment20546> these are en_US too or at least english same goes for the quotes - C. Boemann On Feb. 12, 2013, 4:32 p.m., Heena Mahour wrote: > > --- > This is a

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

<http://git.reviewboard.kde.org/r/108924/#comment20551> These are english so should not be here I believe same goes for the double quotes - C. Boemann On Feb. 12, 2013, 4:38 p.m., Heena Mahour wrote: > > ---

Re: Problem with Getting Started

On Tuesday 12 February 2013 17:46:55 Upul Kumara wrote: > Dear All, >I am quite new to KDE. And I have successfully built calligra. > Someone please tell me the next step of getting involved with calligra as a > developer. > Thank you. > > > Regards, > Upul Kumara. > Dept. Computer Engine

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

> On Feb. 12, 2013, 5 p.m., C. Boemann wrote: > > /usr/share/kde4/apps/calligra/autocorrect/autocorrect.xml, line 12 > > <http://git.reviewboard.kde.org/r/108924/diff/1/?file=113794#file113794line12> > > > > These are english so should not be here I believe &

Re: Review Request 108937: Fix memory leak in KoShapeContainer

; you need to clean up too if the other frames are just copy frames. Like for instance the headers and footers - C. Boemann On Feb. 13, 2013, 6:15 a.m., Thorsten Zachmann wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

> On Feb. 12, 2013, 5 p.m., C. Boemann wrote: > > /usr/share/kde4/apps/calligra/autocorrect/autocorrect.xml, line 12 > > <http://git.reviewboard.kde.org/r/108924/diff/1/?file=113794#file113794line12> > > > > These are english so should not be here I believe &

Review Request 108979: Move KoShapeAnchor to flake

rames/KWFrame.cpp c8677eb words/part/frames/KWFrameLayout.cpp 844359d Diff: http://git.reviewboard.kde.org/r/108979/diff/ Testing --- Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/lis

Re: Review Request 108979: Move KoShapeAnchor to flake

sting --- Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 108979: Move KoShapeAnchor to flake

- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108979/#review27529 --- On Feb. 15, 2013, 6:27 p.m., C. Boemann wrote: > >

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

awfully long list - it becomes almost a spellchecker - are you sure this is really what the user wants usr/share/kde4/apps/calligra/autocorrect/en_US.xml <http://git.reviewboard.kde.org/r/108924/#comment20698> two replacements for the same word?? - C. Boemann On Feb. 17, 2013, 1:

Re: RFC: cleanup tools/, split into developer tools and user extras

On Sunday 17 February 2013 18:54:00 Friedrich W. H. Kossebau wrote: > Hi, > > tools/ is turning into a dumping ground for all kind of stuff that does not > fit into the other dirs. > > At least packagers are left with guessing as e.g. the tools/README is > outdated, so at least the OpenSUSE packa

Re: First Contact. Protege programm.

On Sunday 17 February 2013 16:29:08 simplevolk wrote: > Hi! > I read an article in the journal LinuxFormat (Feb,2013) about Calligra > ,Gnome Office,Libre, etc; > And i read some info about your Academy programm. > > I want to be a Protege in Calligra, because many time i try to find some > openso

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

- > > (Updated Feb. 17, 2013, 1:59 p.m.) > > > Review request for Calligra and C. Boemann. > > > Description > --- > > added some more autocorrection and grammer correction > > > Diffs > - > > usr/share/kde4/apps/calligra

Re: First Contact : Aman Madaan

On Monday 18 February 2013 15:32:36 Aman Madaan wrote: > Hello > > I started on Calligra Words by submitting this little > patch<http://permalink.gmane.org/gmane.comp.kde.cvs/1204340> with > tons of help from C. Boemann and Friedrich W. H. Kossebau. More like the 3 of us ha

Re: Review Request 109002: Turning stage into modebox

cally generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109002/ > --- > > (Updated Feb. 18, 2013, 9:14 a.m.) > > > Review request for Calligra and C. Boemann. > > > Description > ---

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

it still works on mac, if not then we probably should ask yue are there any changes needed for message extraction, and are we now talking different po packages? - C. Boemann On Feb. 21, 2013, 5:24 p.m., Friedrich W. H. Kossebau wrote

Re: Review Request 109082: Separate files for the app into own subdir "app/" for Stage and Words

it still works on mac, if not then we probably should ask yue are there any changes needed for message extraction, and are we now talking different po packages? - C. Boemann On Feb. 21, 2013, 5:24 p.m., Friedrich W. H. Kossebau wrote

Re: Review Request 109088: remove code variants for Qt versions below the current min.requ. 4.7.0

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109088/#review27872 --- Ship it! Ship It! - C. Boemann On Feb. 21, 2013, 9:58 p.m

Re: Review Request 109149: Increase size of QPixmapCache to prevent flickering and infinte redraw in PictureShape

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109149/#review28077 --- Ship it! Ship It! - C. Boemann On Feb. 25, 2013, 4:09 p.m

Re: Review Request 109140: Prevent infinte recursion in PictureShape/SelectionRect due to floating-point errors

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109140/#review28078 --- Ship it! looks good - C. Boemann On Feb. 25, 2013, 12:14

Re: Review Request 109163: Create SimpleSpellCheckWidget

et should be named camelCase plugins/textshape/dialogs/SimpleSpellCheckingWidget.cpp <http://git.reviewboard.kde.org/r/109163/#comment21018> first of it's safe to call delete on a null pointer but since we don't create the action we shouldn't delete it either -

Re: Review Request 109163: Create SimpleSpellCheckWidget

ngWidget.cpp <http://git.reviewboard.kde.org/r/109163/#comment21059> ui.toolAutoSpellCheck->setDefaultAction(tool->action("tool_auto_spellcheck")); - C. Boemann On Feb. 26, 2013, 1:35 a.m., Luke De Mouy wrote: > > --

Re: Review Request 109163: Create SimpleSpellCheckWidget

the other Simple* widgets for example It should be just a plain QWidget at the bottom. The purpose I won't bother to explain, just take my word for it - C. Boemann On Feb. 27, 2013, 4:19 a.m., Luke De Mouy wrote: > > --

Re: 2.7 Release schedule

On Tuesday 26 February 2013 08:31:15 Cyrille Berger wrote: > Hi, > > So what is the conclusion of the release schedule debate ? > > Is the following ok ? > "In this case that would mean, 2.7.0 release the 5th of June, for a > branching > on the 27th of April. Instead of branching on 22nd of Febru

Re: Review Request 109163: Create SimpleSpellCheckWidget

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109163/#review28247 --- Ship it! Ship It! - C. Boemann On Feb. 27, 2013, 6:42 p.m

Re: Review Request 109225: initialize two membes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109225/#review28362 --- Ship it! Ship It! - C. Boemann On March 1, 2013, 3:24 p.m

Re: Review Request 109215: Branch Review for ReviewTool

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109215/#review28363 --- Ship it! I say it's good enough - let's merge to m

Re: Dropping the spreadsheet shape from releases

On Saturday 02 March 2013 11:55:04 Boudewijn Rempt wrote: > Given bugs like https://bugs.kde.org/show_bug.cgi?id=315949, I think we > really should drop the spreadsheet shape. It is not usable and pretty much > unmaintained. I would be happy if we did. no one sems to care for that shape ___

Re: Review Request 109278: fix preedit string problem when layout the document, fix input method query problem in artistictext tool

. Having little way to test it I'm just going to take your word for it that it works. - C. Boemann On March 4, 2013, 3:20 a.m., Yue Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.re

Re: Review Request 109242: Move KoUpdater/KoProgressBar to kowidgets

widgetutils - C. Boemann On March 2, 2013, 1:03 p.m., Boudewijn Rempt wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 108781: Moving Formatting in Calligrawords from old framework to new framework.

as I don't think you have commit rights yet. - C. Boemann On Feb. 28, 2013, 5:40 p.m., Sudhendu Kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Proposal to use Qocoa to support native-look widgets on different platform

On Sunday 10 March 2013 Mar, Yuë Liu wrote: > What's your opinion on this? At leaset we need all the application > maintainers' support. I don't think this is the right way to go. If we want it to look good on osx, we should work on the qstyle, which will benefit other projects as well. It may n

Re: Review Request 109410: set the style to plastique if not running in KDE

hard code the style for krita - at least give the user a way out. It's not impossible that the user is running oxygen or some other style that will work, even if not on KDE - C. Boemann On March 11, 2013, 9:26 a.m., Boudewijn R

Re: Review Request 109410: set the style to plastique if not running in KDE

> On March 11, 2013, 9:35 a.m., C. Boemann wrote: > > Fine with me, but I think it's wrong of you to hard code the style for > > krita - at least give the user a way out. It's not impossible that the user > > is running oxygen or some other style tha

Re: New release "layout": no more alpha, no more RC, just beta

On Thursday 14 March 2013 10:15:53 Cyrille Berger wrote: > Hi, > > As a reminder, our current layout is: > Week 0 -> tag alpha > Week 3 -> branch and tag beta > Week 6 -> tag RC > Week 9 -> tag final > > After some discussions, it has been suggested to do the following > layout: > > Week 3 -> br

Re: Review Request 109508: Added scrollbar to shape-handling in order to restrict its expansion beyond limit

<http://git.reviewboard.kde.org/r/109508/#comment21892> I would think we would need to make sure it has no frame? - C. Boemann On March 15, 2013, 7:47 p.m., Sudhendu Kumar wrote: > > --- > This is an automatically gener

Re: Review Request 109508: Added scrollbar to shape-handling in order to restrict its expansion beyond limit

to master we need to make sure that the area doesn't have a frame, and there should be no extra margins - C. Boemann On March 16, 2013, 11:32 a.m., Sudhendu Kumar wrote: > > --- > This is an automatically generated e-

Re: Review Request 109508: Added scrollbar to shape-handling in order to restrict its expansion beyond limit

to push. thanks libs/main/KoModeBox.cpp <http://git.reviewboard.kde.org/r/109508/#comment21944> setFrameShape(QFrame::NoFrame) just setting shadow to plain will not be enough on all styles - C. Boemann On March 17, 2013, 6:38 a.m., Sudhendu Kumar

Re: Review Request 109649: Make two methods of KoToolManager public

a bit more insecure because what happens if a tool emits done when it was made temporary from the outside. previously nothing, but now it may get out of sync. Not a big problem, but maybe something for you to think about - C. Boemann On March 21, 2013, 8:02 p.m., Dmitry Kazakov

Re: Review Request 109651: Refactor style manager

to push libs/textlayout/KoStyleThumbnailer.cpp <http://git.reviewboard.kde.org/r/109651/#comment22189> paragraphStyleId seems a misnomer now - C. Boemann On March 25, 2013, 5:28 a.m., Thorsten Zachmann wrote: > > ---

Re: Review Request 109386: added underline to preedit string

x27;s about text input - C. Boemann On March 10, 2013, 10:31 a.m., Yue Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revie

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108924/#review29844 --- Ship it! Ship It! - C. Boemann On Feb. 18, 2013, 6:30 a.m

Re: Review Request 107866: Pivot Tables for Calligra Sheets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107866/#review29845 --- isn't this merged already ? - C. Boemann On Jan. 15,

Re: Review Request 109368: Moving Text formatting from old framework to new framework

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109368/#review29849 --- Ship it! Ship It! - C. Boemann On March 9, 2013, 11:55 a.m

Re: Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

r ( or before ) plugins/textshape/ReferencesTool.cpp <http://git.reviewboard.kde.org/r/109746/#comment22365> I wonder if in this case it wouldn't be better to just pop up the manage bookmarks dialog - C. Boemann On March 26, 2013, 7:04 p.m., Aman Madaan wrote: > >

Re: Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

ave to see the error dialog. Forget what I wrote about bringing up the manage dialog, the waning and preventing pressing enter should be enough (the warning should suggest to use "Manage bookmarks" though) - C. Boemann On March 26, 2013, 7:04 p.m., Aman Madaan wrote: > > -

Re: Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

dget.cpp <http://git.reviewboard.kde.org/r/109746/#comment22396> indentation plugins/textshape/dialogs/WeblinkInsertionWidget.cpp <http://git.reviewboard.kde.org/r/109746/#comment22397> indentation - C. Boemann On March 28, 2013, 8:42 p.m., Aman Madaan wrote: > > -

Re: Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

/#comment22440> pretty sure we shouldn't do it like this, but use a dedicated method (instead of insertHtml) plugins/textshape/dialogs/LinkInsertionDialog.cpp <http://git.reviewboard.kde.org/r/109746/#comment22441>

Re: Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

ard.kde.org/r/109746/#comment22467> this should be replaces with a: setValidator() or something - C. Boemann On March 30, 2013, 6:11 p.m., Aman Madaan wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

plugins/textshape/ReferencesTool.cpp <http://git.reviewboard.kde.org/r/109746/#comment22472> indentation plugins/textshape/ReferencesTool.cpp <http://git.reviewboard.kde.org/r/109746/#comment22473> shouldn't you set 1 to blank as well? - C. Boemann On March 30, 2013

Re: Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

e edit to it. that way we don't have to expose an internal widget - C. Boemann On March 30, 2013, 7:42 p.m., Aman Madaan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git

Re: Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

disabled fetch button this should not be reachable - C. Boemann On March 30, 2013, 8:51 p.m., Aman Madaan wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

r 1 here and I think we should let 0 be empty too in this case plugins/textshape/ReferencesTool.cpp <http://git.reviewboard.kde.org/r/109746/#comment22492> we should clear the bokmark name in the widget - C. Boemann On March 31, 2013, 4:17 a.m.,

Re: interface design icons

On Thursday 04 April 2013 19:56:00 geocrea...@myopera.com wrote: > Hi! > > Hello > My name is Jorge Fuentes and I'm interested in designing your interface > icons, but I wonder how have your pack of icons for redesign it. > I mention that I am an amateur designer who wants to contribute. Hi We n

Re: Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

46/#comment22764> only one tab and please place , on the following line like: : fgdfg , fgdfg it makes for fewer merge conflicts - C. Boemann On April 1, 2013, 10:09 p.m., Aman Madaan wrote: > >

Re: Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

single commit. ifin doubt ping meon irc - C. Boemann On April 8, 2013, 8:51 a.m., Aman Madaan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 109926: Statistics info in status bar

g/r/109926/#comment23905> maybe it's just me but i can't find where this is called from - C. Boemann On April 26, 2013, 2:21 p.m., Jérémy BOURDIOL wrote: > > --- > This is an automatically generated e-mail

Re: Review Request 110383: Implement Distraction-Free mode for Words and Author.

semi reviewed every commit on the way so I'm okay with it going in. But the license is a deal breaker for sure And when it does go in can I ask it be committed to master in two parts. 1 ) the stuff in libs and krita 2 ) the stuff in words and in that order naturally due to dependency - C. Bo

Re: Review Request 110129: Add a loadCompleted() signal to KoMainWindow

from the document in question and not from a previous loaded one as in: start load start load emit loadCompleted <- which of the two does it refer to - C. Boemann On May 1, 2013, 7:59 a.m., Dmitry Kazakov wrote: > > --- >

Re: Review Request 110506: Ignore application of default styles in DockerStylesComboModel

> On May 19, 2013, 4:36 a.m., Thorsten Zachmann wrote: > > plugins/textshape/dialogs/DockerStylesComboModel.cpp, lines 156-159 > > > > > > I'm not 100% sure but I think the test for the stylesType is not needed >

Re: Table rows incorrectly rendered in Words

On Wednesday 22 May 2013 10:33:16 Beojan Stanislaus wrote: > With a document created in Microsoft Word (both .doc and .odt formats), > table rows are rendered too narrow, causing the text within to be cut off. > > Would it be possible to ensure all table cells are correctly resized for > their con

Re: Review Request 110609: Update author profile actions when configuration changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110609/#review33022 --- Ship it! Ship It! - C. Boemann On May 23, 2013, 10:22 a.m

Re: Review Request 110624: Epub generation improvement (new metadata)

ttp://git.reviewboard.kde.org/r/110624/#comment24447> and if there is no cover saved? - C. Boemann On May 23, 2013, 8:11 p.m., Jérémy BOURDIOL wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Re: Review Request 110506: Ignore application of default styles in DockerStylesComboModel

e the chance - C. Boemann On May 19, 2013, 9:44 a.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Question about loading and default list/bib/ToC styles

On Tuesday 28 May 2013 11:25:40 Elvis Stansvik wrote: > 2013/5/28 Gopalakrishna Bhat > > > On Tue, May 28, 2013 at 8:56 AM, Thorsten Zachmann wrote: > >> On Monday 27 May 2013 21:19:56 Elvis Stansvik wrote: > >> > Hi all, > >> > > >> > Currently trying to track down a bug and realized I'm a lit

Re: Question about loading and default list/bib/ToC styles

On Tuesday 28 May 2013 16:25:01 Inge Wallin wrote: > On Tuesday, May 28, 2013 09:18:29 Gopalakrishna Bhat wrote: > > On Tue, May 28, 2013 at 8:56 AM, Thorsten Zachmann > > wrote: > > > On Monday 27 May 2013 21:19:56 Elvis Stansvik wrote: > > What we could do is save the DefaultStyle only if it use

Re: Review Request 110696: Fix incrementing of style ID counter in StyleManager

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110696/#review33297 --- Ship it! Ship It! - C. Boemann On May 28, 2013, 2:42 p.m

Re: Review Request 110719: fix KoXmlReader to break on error instead of trying on and on

itted this without asking :) - C. Boemann On May 29, 2013, 11:54 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 110708: Add some basic unit tests for the style manager

on this - C. Boemann On May 29, 2013, 11:04 a.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 110700: Remove unused storage/API from StyleManager

o the final merge to master can be done in a clean way - C. Boemann On May 28, 2013, 8:18 p.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 110700: Remove unused storage/API from StyleManager

> On May 30, 2013, 6:44 a.m., C. Boemann wrote: > > it looks okay and as such is committable, but I would prefer we have the > > followup solution before actually merging to master, so please in a local > > branch where you work on the next steps. When time comes this co

Re: Anatomy of the style manager

On Thursday 30 May 2013 14:19:24 Pierre Stirnweiss wrote: > PierreSt, who is actually still alive good to hear :) ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 110723: Add tests for adding applied styles and applying added styles

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110723/#review33443 --- Ship it! Ship It! - C. Boemann On May 30, 2013, 1:30 p.m

Re: Review Request 110593: Check for null image in drop event

to be unrelated so please commit - C. Boemann On May 22, 2013, 1:39 p.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc

/110821/diff/ Testing --- Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc

) has the wrong position (too much to the right) pasting of url of an image (using toolproxy) is not yet implemented. Most often seen when dragging an image from a webbrowser - C. Boemann On June 3, 2013, 6:05 p.m., C. Boemann wrote

Re: Review Request 110928: Always save the position of a shape

asked to (by setting the OdfPosition flag) I'm not even sure why not saving 0,0 is wrong? But the way you solve it looks wrong to me. - C. Boemann On June 10, 2013, 8:13 a.m., Inge Wallin wrote: > > --- > This is an automa

Re: Review Request 110928: Always save the position of a shape

stand why we need to save 0,0 - C. Boemann On June 10, 2013, 5:37 p.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 110949: Renaming "Page Borders" to "Page Markers" in Calligra Sheets

you should be able to change that by replacing in the diff file and applying the diff to a clean tree) - C. Boemann On June 11, 2013, 5:24 a.m., Jigar Raisinghani wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 110928: Always save the position of a shape

> On June 10, 2013, 5:52 p.m., C. Boemann wrote: > > I still don't see the relation to the bug nor do I understand why we need > > to save 0,0 > > Inge Wallin wrote: > Ah, now I understand why everybody focusses on the bug. I was unclear in > my

Re: Review Request 111044: Implement borders for shapes

omment25278> in particular this else should not be there but i'm not sure removing it is enough, because on one level only i belive border has precedence over border-xyz libs/odf/KoBorder.cpp <http://git.reviewboard.kde.org/r/111044/#comment25279> same about this else - C

Re: Review Request 111031: rename all filter modules to calligra_filter_formatx2formaty (instead of current namespaceless names)

filter can support more than one conversion? - C. Boemann On June 14, 2013, 11:08 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Plan, Karbon: Disable the "Maintainer wanted" splashscreen for release branches?

On Tuesday 18 June 2013 01:41:50 Elvis Stansvik wrote: > 2013/6/18 Friedrich W. H. Kossebau > > > Hi, > > > > I wonder if it is a go idea to have the "Maintainer wanted" splashscreen > > in Plan and Karbon also enabled in the 2.7 releases. People who still > > see some use in either programs sur

Re: Review Request 111147: Rename KoCanvasResourceManager::resourceChanged

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/47/#review34739 --- Ship it! Ship It! - C. Boemann On June 20, 2013, 8:53 a.m

Re: Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc

y generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110821/#review34895 ------- On June 3, 2013, 6:05 p.m., C. Boemann wrote: > > --- > This is an autom

Re: Review Request 111031: rename all filter modules to calligra_filter_formatx2formaty (instead of current namespaceless names)

scan - looks simple enought - C. Boemann On June 18, 2013, 10:32 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 111286: Remove useless textvariableplugin.desktop

ed in plugins/variables Thanks for catching it - C. Boemann On June 27, 2013, 9:40 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 111305: "ko"-prefix installed, but so far namespace-less libs: msooxml, odfreader, vectorimage, textlayout

prefix is something we have to endure with librarynames. - C. Boemann On June 29, 2013, 12:40 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboa

Re: Review Request 111044: Implement borders for shapes

visit: > http://git.reviewboard.kde.org/r/111044/ > --- > > (Updated June 22, 2013, 6:28 a.m.) > > > Review request for Calligra, C. Boemann, Boudewijn Rempt, and Thorsten > Zachmann. > > > Description > --- > > This

Re: Review Request 111321: Solve bug 283164: delete key doesn't delete multiple cells

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111321/#review35315 --- has my backing :) - C. Boemann On June 30, 2013, 2:55 a.m

Re: HUGE regression in sheets

I have a fix :) On Friday 19 July 2013 08:36:25 Inge Wallin wrote: > I have found a huge regression in sheets. > > I and Cyrille wanted to release 2.7.0 on monday. I have set aside time > during the weekend for the announcement and a visual changelog. > > But I have found a huge regression in s

Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

--- just working with it, and fixing the reviews from the earlier review Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

<    5   6   7   8   9   10   11   >