> On March 11, 2013, 9:35 a.m., C. Boemann wrote: > > Fine with me, but I think it's wrong of you to hard code the style for > > krita - at least give the user a way out. It's not impossible that the user > > is running oxygen or some other style that will work, even if not on KDE > > Boudewijn Rempt wrote: > Well, I can check whether the current style is oxygen, and if not, enable > plastique, or even enable plastique, then try to enable oxygen (which is > better than plastique). Or make the style configurable in krita's settings > dialog. But I don't want to risk anyone to start krita with another style > than these two -- I haven't seen a single style other than these that is not > broken.
it's just a very presumptious thing to hardcode it. Now how will a style coder be able to test with krita and make it better. While I fully understand your position, I think it's wrong to not give the user a way out so a solution would that style configuration with 3 choices: - oxygen - plastique - system default (most styles look bad, complain to their creator, not to us) - C. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109410/#review28949 ----------------------------------------------------------- On March 11, 2013, 9:26 a.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109410/ > ----------------------------------------------------------- > > (Updated March 11, 2013, 9:26 a.m.) > > > Review request for Calligra. > > > Description > ------- > > For Krita, with its default dark theme, only two styles work: oxygen and > plastique. Oxygen is default in KDE, if the user selects something else, it's > their problem. On windows, osx and ubuntu, the default style is broken for > krita, so hard-code plastique if the user is running krita outside KDE. > > This means that on Windows, other apps than Krita will use the default > windows style again. It might be worth it to reinstate the code that detects > the windows version and sets the right style, but that is up for discussion. > > > Diffs > ----- > > libs/main/KoApplication.cpp 87536f1 > > Diff: http://git.reviewboard.kde.org/r/109410/diff/ > > > Testing > ------- > > > Thanks, > > Boudewijn Rempt > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
