----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110700/#review33396 -----------------------------------------------------------
Ship it! it looks okay and as such is committable, but I would prefer we have the followup solution before actually merging to master, so please in a local branch where you work on the next steps. When time comes this commit does/should not be squashed with the rest. If you keep it local it's easy to rebase and ammend the commit if needed, and so the final merge to master can be done in a clean way - C. Boemann On May 28, 2013, 8:18 p.m., Elvis Stansvik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110700/ > ----------------------------------------------------------- > > (Updated May 28, 2013, 8:18 p.m.) > > > Review request for Calligra, C. Boemann, Gopalakrishna Bhat, Pierre > Stirnweiss, and Thorsten Zachmann. > > > Description > ------- > > In KoStyleManager, nothing is ever added to the d->unusedParagraphStyles > hash, so I suggest we remove it along with the accompanying API. > > I'm guessing it was an unfinished attempt to make ToC/bibliography styles not > appear at all in the UI until they're used (I mean, not even appear as > "Unused") ? > > The code that used the API were the bibliography and ToC templates, but > nothing was ever inserted into d->unusedParagraphStyles. > > > Diffs > ----- > > libs/kotext/styles/KoStyleManager.h c44ba32 > libs/kotext/styles/KoStyleManager.cpp f7b9b5f > libs/textlayout/ToCGenerator.cpp 30df21e > plugins/textshape/dialogs/BibliographyTemplate.h 99ca6c4 > plugins/textshape/dialogs/BibliographyTemplate.cpp 4bb2bd0 > plugins/textshape/dialogs/SimpleCitationBibliographyWidget.cpp c93a673 > plugins/textshape/dialogs/SimpleTableOfContentsWidget.cpp 48fb88e > plugins/textshape/dialogs/TableOfContentsTemplate.h f98f6f9 > plugins/textshape/dialogs/TableOfContentsTemplate.cpp 2bd73e7 > > Diff: http://git.reviewboard.kde.org/r/110700/diff/ > > > Testing > ------- > > Tested bibliography functionality before/after the removal. There was no > change in behavior that I could see. > > > Thanks, > > Elvis Stansvik > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
