----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109149/#review28077 -----------------------------------------------------------
Ship it! Ship It! - C. Boemann On Feb. 25, 2013, 4:09 p.m., Arjen Hiemstra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109149/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2013, 4:09 p.m.) > > > Review request for Calligra. > > > Description > ------- > > With larger images, the default size of QPixmapCache is too small to properly > cache the results of the scaled image used by PictureShape. This causes > flickering and infinite redraws when multiple images overlap due to one image > being removed from the cache when another is added. This patch changes that > to use a default size equal to 5 images of 2048 x 1024 x 32bpp. This > potentially increases the memory usage of documents with lots of pictures but > prevents the repainting and flickering issues. > > > Diffs > ----- > > plugins/pictureshape/Plugin.cpp 6e12b41 > > Diff: http://git.reviewboard.kde.org/r/109149/diff/ > > > Testing > ------- > > Build and run. Tested the pictureshape and it no longer flickers when > overlapping. > > > Thanks, > > Arjen Hiemstra > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
