----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109746/#review30573 -----------------------------------------------------------
plugins/textshape/ReferencesTool.cpp <http://git.reviewboard.kde.org/r/109746/#comment22755> if not used then this needs to go plugins/textshape/dialogs/LinkInsertionDialog.cpp <http://git.reviewboard.kde.org/r/109746/#comment22756> too many spaces after } plugins/textshape/dialogs/LinkInsertionDialog.cpp <http://git.reviewboard.kde.org/r/109746/#comment22758> we shouldn't hardcode red on some color schemes it will not be visible. unfortunately qpalette doesn't have a warning role, but i know we have in kde. Questions is if this is the time to add another dependency on kde. maybe we should just go with standard textcolor for now plugins/textshape/dialogs/LinkInsertionDialog.cpp <http://git.reviewboard.kde.org/r/109746/#comment22759> maybe just "Fetch timed out" plugins/textshape/dialogs/LinkInsertionDialog.cpp <http://git.reviewboard.kde.org/r/109746/#comment22760> kDebug with area number or no debug at all plugins/textshape/dialogs/LinkInsertionDialog.cpp <http://git.reviewboard.kde.org/r/109746/#comment22761> same here, and please chec if you have any other qDebug plugins/textshape/dialogs/LinkInsertionDialog.cpp <http://git.reviewboard.kde.org/r/109746/#comment22762> title plugins/textshape/dialogs/LinkInsertionDialog.cpp <http://git.reviewboard.kde.org/r/109746/#comment22763> title plugins/textshape/dialogs/ManageBookmarkDialog.cpp <http://git.reviewboard.kde.org/r/109746/#comment22764> only one tab and please place , on the following line like: : fgdfg , fgdfg it makes for fewer merge conflicts - C. Boemann On April 1, 2013, 10:09 p.m., Aman Madaan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109746/ > ----------------------------------------------------------- > > (Updated April 1, 2013, 10:09 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This patch adds the following features : > > 1. Inserting hyperlinks > -- User has a choice of inserting a link by specifying the target and the > link text. Additionally, the > user may supply values for target and rel attributes using a drop down > list. > -- The user may fetch the title from the web page itself (contents of the > "title" tag ). This feature also > handles URL redirects. For example, ieee.com is finally redirected to > http://www.ieee.org/index.html. > This feature will especially help in cases when a user has a list of > links referred to and a list of > references has to be created. Just copy/pasting the URL, clicking fetch > and then insert will do the job. > > 2. Linking to bookmarks > -- A user can specify a bookmark name and the link text. To help the user > with inserting bookmark, > an auto completer is used. This becomes helpful when the bookmarks have > been given a name that > are related to the context. (lastpagefirstpara or conclusions). > > 3. Adding Bookmark using a labeled widget ( similar to the way footnote and > endnote labels are entered ) > > > Diffs > ----- > > plugins/textshape/dialogs/SimpleLinksWidget.ui PRE-CREATION > plugins/textshape/dialogs/SimpleLinksWidget.cpp PRE-CREATION > plugins/textshape/dialogs/SimpleLinksWidget.h PRE-CREATION > plugins/textshape/dialogs/ManageBookmarkDialog.cpp PRE-CREATION > plugins/textshape/dialogs/ManageBookmarkDialog.h PRE-CREATION > plugins/textshape/dialogs/ManageBookmark.ui PRE-CREATION > plugins/textshape/dialogs/LinkInsertionDialog.ui PRE-CREATION > plugins/textshape/dialogs/LinkInsertionDialog.cpp PRE-CREATION > plugins/textshape/dialogs/LinkInsertionDialog.h PRE-CREATION > plugins/textshape/ReferencesTool.cpp 46bf06f > plugins/textshape/ReferencesTool.h 21caea8 > plugins/textshape/CMakeLists.txt b2bf9ae > libs/kotext/KoTextEditor.cpp 07bcad8 > libs/kotext/KoTextEditor.h f96ab70 > > Diff: http://git.reviewboard.kde.org/r/109746/diff/ > > > Testing > ------- > > I have tested the following components : > > 1 Inserting Hyperlinks > 1.1 Simplest case (works) > 1.2 Fetch title from URL (works) > 1.3 Fetch title from URL which has re directions (works) > 1.4 specify a URL without a scheme (works, appending an http:// to all the > schemeless urls) > 1.5 fetching from an non existing URL (Time out occurs and notifies user > about the same) > > 2 Adding Bookmarks > 2.1 Simplest case (works) > 2.2 Adding a duplicate bookmark i.e. using a name that has been used > before(User is notified and bookmark addition is aborted) > > 3 Adding link to a bookmark > 3.1 Simplest case (works) > 3.2 Adding a link to a non existing bookmark (works,User is notified about > non existence of the bookmark) > > 4 Manage bookmarks > 4.1 user clicks on manage bookmarks (works, Copy pasted the existing > implementation. Looks like delete bookmark is broken.) > > > Thanks, > > Aman Madaan > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
