----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109386/#review29843 -----------------------------------------------------------
Ship it! fine with me ad thanks for working on this aspect libs/textlayout/KoTextLayoutArea_paint.cpp <http://git.reviewboard.kde.org/r/109386/#comment22191> I have no way to test this, but if you think it makes sense as a user feel free to commit it. Adding a comment or two would be appreciated, especially at this line saying it's about text input - C. Boemann On March 10, 2013, 10:31 a.m., Yue Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109386/ > ----------------------------------------------------------- > > (Updated March 10, 2013, 10:31 a.m.) > > > Review request for Calligra. > > > Description > ------- > > added underline to preedit string. > > > Diffs > ----- > > libs/textlayout/KoTextLayoutArea_paint.cpp > d0386d9b6787662c4e578310f94922f84c8c075e > > Diff: http://git.reviewboard.kde.org/r/109386/diff/ > > > Testing > ------- > > works fine. But there are bugs from other parts blocking the final result so > part of the rendering results not shown. > > > Thanks, > > Yue Liu > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
