----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109649/#review29659 -----------------------------------------------------------
Ship it! in theory nothing against it, but maybe it's a bit more insecure because what happens if a tool emits done when it was made temporary from the outside. previously nothing, but now it may get out of sync. Not a big problem, but maybe something for you to think about - C. Boemann On March 21, 2013, 8:02 p.m., Dmitry Kazakov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109649/ > ----------------------------------------------------------- > > (Updated March 21, 2013, 8:02 p.m.) > > > Review request for Calligra. > > > Description > ------- > > In this big patch I need a review for a small part only (on the last page of > diff viewer). There is a change to KoToolManager. I made two methods for > temporary switching public. Before the change only a tool-based-class could > switch the tool temporarily. Now everyone can do it. > > This change is needed to allow activation of the Color Picker tool from the > filter dialog in Krita. When the dialog is shown, the picker is temporarily > activated. When the dialog is gone, the tool is switched back. > > > Diffs > ----- > > krita/image/kis_base_processor.h a135075 > krita/image/kis_base_processor.cpp 7ec48ec > krita/image/kis_config_widget.h 87d1d3a > krita/image/kis_config_widget.cpp 87a9aae > krita/plugins/extensions/shiva/shivafilter.h 9e0630d > krita/plugins/extensions/shiva/shivafilter.cpp 8617005 > krita/plugins/extensions/shiva/shivagenerator.h 96fe730 > krita/plugins/extensions/shiva/shivagenerator.cpp 89c9497 > krita/plugins/filters/blur/kis_blur_filter.h 4546485 > krita/plugins/filters/blur/kis_blur_filter.cpp ba9c07d > krita/plugins/filters/blur/kis_gaussian_blur_filter.h 6cc214e > krita/plugins/filters/blur/kis_gaussian_blur_filter.cpp d2dd8a1 > krita/plugins/filters/blur/kis_lens_blur_filter.h 3c607d6 > krita/plugins/filters/blur/kis_lens_blur_filter.cpp 775efd6 > krita/plugins/filters/blur/kis_motion_blur_filter.h 2ae9f0e > krita/plugins/filters/blur/kis_motion_blur_filter.cpp e415244 > krita/plugins/filters/colors/kis_color_to_alpha.h 71c3bee > krita/plugins/filters/colors/kis_color_to_alpha.cpp 73eaf0f > krita/plugins/filters/colors/kis_wdg_color_to_alpha.h 757c601 > krita/plugins/filters/colors/kis_wdg_color_to_alpha.cpp 5029522 > krita/plugins/filters/colors/wdgcolortoalphabase.ui 0a2b8ff > krita/plugins/filters/colorsfilters/kis_brightness_contrast_filter.h > 31c88b5 > krita/plugins/filters/colorsfilters/kis_brightness_contrast_filter.cpp > 4375d9c > krita/plugins/filters/colorsfilters/kis_hsv_adjustment_filter.h 0a818fa > krita/plugins/filters/colorsfilters/kis_hsv_adjustment_filter.cpp 5b5bc3a > krita/plugins/filters/colorsfilters/kis_perchannel_filter.h 59ee020 > krita/plugins/filters/colorsfilters/kis_perchannel_filter.cpp 85f72c3 > krita/plugins/filters/dodgeburn/DodgeBurn.h 7ef27f2 > krita/plugins/filters/dodgeburn/DodgeBurn.cpp b2ae46c > krita/plugins/filters/embossfilter/kis_emboss_filter.h 3b71978 > krita/plugins/filters/embossfilter/kis_emboss_filter.cpp 17611af > krita/plugins/filters/fastcolortransfer/fastcolortransfer.h 23cccfd > krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp 5dab33f > krita/plugins/filters/imageenhancement/kis_simple_noise_reducer.h c3bb4b9 > krita/plugins/filters/imageenhancement/kis_simple_noise_reducer.cpp e514c13 > krita/plugins/filters/imageenhancement/kis_wavelet_noise_reduction.h > 577172d > krita/plugins/filters/imageenhancement/kis_wavelet_noise_reduction.cpp > 2ddd372 > krita/plugins/filters/levelfilter/kis_level_filter.h 751d8baf4 > krita/plugins/filters/levelfilter/kis_level_filter.cpp c13f859 > krita/plugins/filters/noisefilter/noisefilter.h 35c654a > krita/plugins/filters/noisefilter/noisefilter.cpp ef66c9d > krita/plugins/filters/oilpaintfilter/kis_oilpaint_filter.h e3d5ccc > krita/plugins/filters/oilpaintfilter/kis_oilpaint_filter.cpp 3c3e7ee > krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_config_widget.h > 85016da > krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_config_widget.cpp > 3416f7d > krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_filter.h ffe5b0b > krita/plugins/filters/phongbumpmap/kis_phong_bumpmap_filter.cpp 68047ad > krita/plugins/filters/pixelizefilter/kis_pixelize_filter.h 8b2356a > krita/plugins/filters/pixelizefilter/kis_pixelize_filter.cpp 1ab5604 > krita/plugins/filters/raindropsfilter/kis_raindrops_filter.h 54302d4 > krita/plugins/filters/raindropsfilter/kis_raindrops_filter.cpp e54fb84 > krita/plugins/filters/randompickfilter/randompickfilter.h 6f7ef59 > krita/plugins/filters/randompickfilter/randompickfilter.cpp 72dac1b > krita/plugins/filters/roundcorners/kis_round_corners_filter.h 5fbd1a9 > krita/plugins/filters/roundcorners/kis_round_corners_filter.cpp 69a521a > krita/plugins/filters/smalltilesfilter/kis_small_tiles_filter.h d7a63fd > krita/plugins/filters/smalltilesfilter/kis_small_tiles_filter.cpp 5acf358 > krita/plugins/filters/sobelfilter/kis_sobel_filter.h c89262f > krita/plugins/filters/sobelfilter/kis_sobel_filter.cpp ede9dc9 > krita/plugins/filters/unsharp/kis_unsharp_filter.h 74a6546 > krita/plugins/filters/unsharp/kis_unsharp_filter.cpp 316c3d0 > krita/plugins/filters/wavefilter/wavefilter.h 7c92b51 > krita/plugins/filters/wavefilter/wavefilter.cpp 9ca6475 > krita/plugins/generators/solid/colorgenerator.h f208bcc > krita/plugins/generators/solid/colorgenerator.cpp e24c3cc > krita/plugins/paintops/libpaintop/kis_filter_option.cpp ec147bf > krita/plugins/tools/defaulttools/kis_tool_colorpicker.h 2c9b600 > krita/plugins/tools/defaulttools/kis_tool_colorpicker.cc ea0c493 > krita/ui/dialogs/kis_dlg_adj_layer_props.h 77ccc7a > krita/ui/dialogs/kis_dlg_adj_layer_props.cc b997855 > krita/ui/dialogs/kis_dlg_adjustment_layer.h 69face4 > krita/ui/dialogs/kis_dlg_adjustment_layer.cc c8b402e > krita/ui/dialogs/kis_dlg_filter.h 34c9ab5 > krita/ui/dialogs/kis_dlg_filter.cpp b354269 > krita/ui/dialogs/kis_dlg_generator_layer.h e9d17ab > krita/ui/dialogs/kis_dlg_generator_layer.cpp a9a0de7 > krita/ui/forms/wdgfilterdialog.ui 6a122c9 > krita/ui/kis_layer_manager.cc 8ee525d > krita/ui/kis_mask_manager.h 2d3d621 > krita/ui/kis_mask_manager.cc 1661d76 > krita/ui/recorder/kis_recorded_filter_action_editor.cc 5a6adab > krita/ui/widgets/kis_filter_selector_widget.h 1fb954e > krita/ui/widgets/kis_filter_selector_widget.cc 0107bb2 > krita/ui/widgets/kis_wdg_generator.h 93a171a > krita/ui/widgets/kis_wdg_generator.cpp b13a41d > libs/flake/KoToolManager.h 929f127 > libs/flake/KoToolManager.cpp d2db044 > > Diff: http://git.reviewboard.kde.org/r/109649/diff/ > > > Testing > ------- > > > Thanks, > > Dmitry Kazakov > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
