----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108882/#review27109 -----------------------------------------------------------
You have made many virtual protecte methods only call the superclass Now I we are going to implment them soon it makes sense to keep them, so ok to commit to your branch when you have fixed below comments plugins/textshape/ReviewTool.h <http://git.reviewboard.kde.org/r/108882/#comment20442> please remove spaces wherever this red color is shown plugins/textshape/ReviewTool.cpp <http://git.reviewboard.kde.org/r/108882/#comment20441> removing copyrights is wrong. - C. Boemann On Feb. 10, 2013, 1:13 a.m., Luke De Mouy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108882/ > ----------------------------------------------------------- > > (Updated Feb. 10, 2013, 1:13 a.m.) > > > Review request for Calligra. > > > Description > ------- > > A part rewrite, part port of ReviewTool over to TextTool. > > > Diffs > ----- > > plugins/textshape/ReviewTool.h 256f08c > plugins/textshape/ReviewTool.cpp b1732be > > Diff: http://git.reviewboard.kde.org/r/108882/diff/ > > > Testing > ------- > > > Thanks, > > Luke De Mouy > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
