----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109163/#review28092 -----------------------------------------------------------
plugins/textshape/dialogs/SimpleSpellCheckingWidget.cpp <http://git.reviewboard.kde.org/r/109163/#comment21017> now i get why you were no sure. this is wrong you create the action in the tool Here you just call ui->tool_auto_spellcheck->setDefaultAction() see some of the other Simple* classes also the widget should be named camelCase plugins/textshape/dialogs/SimpleSpellCheckingWidget.cpp <http://git.reviewboard.kde.org/r/109163/#comment21018> first of it's safe to call delete on a null pointer but since we don't create the action we shouldn't delete it either - C. Boemann On Feb. 26, 2013, 1:15 a.m., Luke De Mouy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109163/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2013, 1:15 a.m.) > > > Review request for Calligra. > > > Description > ------- > > Created the SimpleSpellCheckWidget class and .ui file, has one KAction > entitled tool_auto_spellcheck which is parented by the QToolButton > ui->tool_auto_spellcheck > > > Diffs > ----- > > plugins/textshape/CMakeLists.txt 4cd1b91 > plugins/textshape/dialogs/SimpleSpellCheckingWidget.h PRE-CREATION > plugins/textshape/dialogs/SimpleSpellCheckingWidget.cpp PRE-CREATION > plugins/textshape/dialogs/SimpleSpellCheckingWidget.ui PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109163/diff/ > > > Testing > ------- > > > Thanks, > > Luke De Mouy > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
