Re: Review Request: Use a parameter instead of concatenation in forming undo/redo action texts

2012-09-27 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106586/#review19484 --- Ship it! Ship It! - C. Boemann On Sept. 27, 2012, 1:31 a.m

Re: Review Request: This increases the flexibility of Statistics Docker Plugin , by allowing it to layout its widgets horizontally when user places it in the bottom area

2012-09-27 Thread C. Boemann
> On Sept. 3, 2012, 9:48 p.m., Jarosław Staniek wrote: > > A number of suggestions to fight clutter a bit: > > - Should 'East asian characters' be visible by default? If there are o > > asian characters maybe you could hide the label. > > - Flesch reading ease -> Reading ease > >(I noted thi

Re: Review Request: Move Show Statusbar action from menu Settings to menu View

2012-09-30 Thread C. Boemann
nk we should try to have it look the same. - C. Boemann On Sept. 30, 2012, 12:10 a.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Annotations

2012-09-30 Thread C. Boemann
On Sunday 30 September 2012 01:33:11 Inge Wallin wrote: > It is now just under a month left until the branching of 2.6 and I'm > getting worried. So here are some questions regarding annotations in > Words. > > 1. Camilla wanted to refactor some aspects of loading and saving in Words > (or kotext?

Re: Review Request: Separate the so called style docker (stroke/fill docker) into a docker and a widget

2012-09-30 Thread C. Boemann
he go-ahead. - C. Boemann On Sept. 29, 2012, 6 p.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: Add functionality to video shape

2012-10-07 Thread C. Boemann
plugins/videoshape/VideoData.cpp <http://git.reviewboard.kde.org/r/106756/#comment15873> I know I wrote this, but 8192 seems a better value, if we don't want to up it even further or do something even better - C. Boemann On

Re: Review Request: Enable a much superior html export filter

2012-10-14 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106840/#review20304 --- Ship it! Ok let's give it a go then - C. Boemann O

Re: Review Request: write entry in manifest for thumbnail file

2012-10-18 Thread C. Boemann
g/r/106941/#comment16235> uhm it should be written by saveOasisPreview no? I think I removed this not that many weeks / months ago (not sure) can't recall why, but i don't feel confident approving this just yet - C. Boemann On Oct. 18, 2012, 10:41 a.m., Friedrich W. H

Re: Review Request: write entry in manifest for thumbnail file

2012-10-18 Thread C. Boemann
> On Oct. 18, 2012, 9:43 p.m., C. Boemann wrote: > > libs/main/KoDocument.cpp, line 660 > > <http://git.reviewboard.kde.org/r/106941/diff/1/?file=91059#file91059line660> > > > > uhm it should be written by saveOasisPreview no? > > > >

Re: Review Request: Roundtrip master documents

2012-10-18 Thread C. Boemann
<http://git.reviewboard.kde.org/r/106942/#comment16237> spaces - C. Boemann On Oct. 18, 2012, 10:58 a.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Re: Review Request: Add functionality to video shape

2012-10-20 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106756/#review20603 --- Ship it! Ship It! - C. Boemann On Oct. 20, 2012, 5:28 p.m

Review Request: Introduce KoTextRange instead of inline characters

2012-10-22 Thread C. Boemann
ark.h 3620385 words/part/tests/TestKoBookmark.cpp cfb65bc words/part/tests/TestRdf.cpp b1cf93c Diff: http://git.reviewboard.kde.org/r/106983/diff/ Testing --- Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org

Re: Review Request: Introduce KoTextRange instead of inline characters

2012-10-24 Thread C. Boemann
words/part/KWView.cpp 65f6165 words/part/frames/KWTextFrameSet.cpp 35f4d8e words/part/tests/TestKoBookmark.h 3620385 words/part/tests/TestKoBookmark.cpp cfb65bc words/part/tests/TestRdf.cpp b1cf93c Diff: http://git.reviewboard.kde.org/r/106983/diff/ Testing --- Thanks, C. Bo

Re: Review Request: Move the theme manager from Krita to KoMainWindow

2012-10-24 Thread C. Boemann
hemed, but Iøm not objecting to this either I'll let someone else approve though - C. Boemann On Oct. 23, 2012, 7:28 a.m., Boudewijn Rempt wrote: > > --- > This is an automatically generated e-mail. To r

Re: Architecture Refactor Suggestion: App-irrelevent Format Filters

2012-10-25 Thread C. Boemann
On Sunday 21 October 2012 10:19:47 Boudewijn Rempt wrote: > On Sunday 21 October 2012 Oct, Yue Liu wrote: > > Hi, > > > > Currently filters are loaded based on application's native mime-type. > > And now we have multiple applications with same native format, such as > > Karbon and Flow, Words and

Re: Review Request: Introduce KoTextRange instead of inline characters

2012-10-25 Thread C. Boemann
it had to be fixed by removing the review and I > > don't have enough energy to go through the whole thing again. Anyway it > > was just trivialities, just go ahead and merge. > > > > > > - Inge > > > > On October 24th, 2012, 11:44 a.m., C. Boemann

Re: Welcome dialog prevents immediate use of application

2012-10-25 Thread C. Boemann
On Wednesday 24 October 2012 13:33:42 Jaroslaw Staniek wrote: > On 24 October 2012 13:18, Paul Gideon Dann wrote: > > On Wednesday 24 Oct 2012 13:12:08 Jaroslaw Staniek wrote: > >> Yes, do you know you don't have to convince me? :) See > >> http://www.calligra.org/news/first-beta-version-of-the-c

Re: Review Request: Introduce roundtripping for annotations

2012-10-28 Thread C. Boemann
So you are basically handling annotation and annotation-start in one go? It doesn't seem completely safe to me but oh well libs/widgets/CMakeLists.txt <http://git.reviewboard.kde.org/r/107088/#comment16544> more trailing space - C. Boemann

Re: Calligra 2.6 Beta changelog

2012-11-01 Thread C. Boemann
On Sunday 28 October 2012 19:14:46 Cyrille Berger Skott wrote: > Hi, > > Please answer with the features/fixes you have added since the alpha three > weeks ago. Words Navigating to bookmarks via dialog (edit menu) now works ___ calligra-devel mailing l

Re: Review Request: CWOP: Icons in dockers are too small because of chrome around

2012-11-03 Thread C. Boemann
think it's not something we as an application should enforce. I'm really torn here. Will think it over a couple of hours - C. Boemann On Nov. 3, 2012, 6:14 p.m., Sven Langkamp wrote: > > --- > This is an automatical

Re: [calligra] plugins/textshape/dialogs: use flat buttons in the textshape docker

2012-11-04 Thread C. Boemann
On Sunday 04 November 2012 14:14:08 Friedrich W. H. Kossebau wrote: > Am Sonntag, 4. November 2012, 13:32:36 schrieb Sven Langkamp: > > Git commit cc10e194166f5c63cf5fb546a9c432e655f84bd8 by Sven Langkamp. > > Committed on 04/11/2012 at 13:30. > > Pushed by langkamp into branch 'master'. > > > >

Re: Review Request: Fixed deactivation of the tools when input device is switched

2012-11-05 Thread C. Boemann
this as a backport. Even as going into master it's should be very thoroughly tested by a lot of different users - C. Boemann On Nov. 5, 2012, 7:52 a.m., Dmitry Kazakov wrote: > > --- > This is an automatically generated e-

Re: Review Request: Autosave only triggered on first change.

2012-11-05 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107206/#review21438 --- Ship it! yes please backport too - C. Boemann On Nov. 5

Re: Review request: undo stack not cleaned on saving

2012-11-05 Thread C. Boemann
On Monday 05 November 2012 16:26:06 Dag wrote: > Reviewboard refuses my patch... > > The result is that [modified] indication is not in sync with file content, > so user may accidently loose data. how do you see the problem? ___ calligra-devel mailing li

Re: Review request: undo stack not cleaned on saving

2012-11-05 Thread C. Boemann
On Monday 05 November 2012 16:46:26 Dag wrote: > Mandag den 5. november 2012 16:35:51 skrev C. Boemann: > > On Monday 05 November 2012 16:26:06 Dag wrote: > > > Reviewboard refuses my patch... > > > > > > The result is that [modified] indication is not in sync

Review Request: autocorrect config file lookup change

2012-11-06 Thread C. Boemann
ecial file So a better suggestion is appreciated Diffs - plugins/textediting/autocorrection/Autocorrect.h 5b76121 plugins/textediting/autocorrection/Autocorrect.cpp 53fdee6 Diff: http://git.reviewboard.kde.org/r/107229/diff/ Testing --- Thanks, C. Bo

Re: Review Request: autocorrect config file lookup change

2012-11-06 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107229/#review21494 ------- On Nov. 6, 2012, 5:54 p.m., C. Boemann wrote: > > ---

Re: Review Request: autocorrect config file lookup change

2012-11-06 Thread C. Boemann
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > <http://git.reviewboard.kde.org/r/107229/diff/1/?file=93886#file93886line707> > > > > You never breaks here ? > > So you will

Re: Review Request: autocorrect config file lookup change

2012-11-06 Thread C. Boemann
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > <http://git.reviewboard.kde.org/r/107229/diff/1/?file=93886#file93886line707> > > > > You never breaks here ? > > So you will

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread C. Boemann
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > <http://git.reviewboard.kde.org/r/107229/diff/1/?file=93886#file93886line707> > > > > You never breaks here ? > > So you will

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread C. Boemann
> On Nov. 6, 2012, 6:04 p.m., Laurent Montel wrote: > > plugins/textediting/autocorrection/Autocorrect.cpp, line 707 > > <http://git.reviewboard.kde.org/r/107229/diff/1/?file=93886#file93886line707> > > > > You never breaks here ? > > So you will

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread C. Boemann
http://git.reviewboard.kde.org/r/107229/diff/ Testing --- Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: autocorrect config file lookup change

2012-11-07 Thread C. Boemann
ocorrect.h 5b76121 plugins/textediting/autocorrection/Autocorrect.cpp b26df0b Diff: http://git.reviewboard.kde.org/r/107229/diff/ Testing --- Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailma

Re: "Uncompressed XML Files" format variants

2012-11-11 Thread C. Boemann
On Monday 12 November 2012 01:34:03 Friedrich W. H. Kossebau wrote: > Hi, > > I would propose to remove the option "Uncompressed XML Files" for non- > developer buils, or positively said, only enable it for developer builds. > Reasoning: > * only confuses the user ("what is the difference to comp

Re: Need help with reviewing and testing the KoToolManager changes

2012-11-12 Thread C. Boemann
On Monday 12 November 2012 18:00:47 Dmitry Kazakov wrote: > Hi! > > Some time ago I've done a patch [0] for the KoToolManager, which fixes the > deactivation of tools while switching the input device. This patch is > completely necessary for fixing the bug 298584 in Krita, because otherwise > Krit

Re: Review Request: Fixed deactivation of the tools when input device is switched

2012-11-12 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107205/#review21881 --- Ship it! good enough for master - C. Boemann On Nov. 5

Re: Review Request: libs/vectorimage

2012-11-15 Thread C. Boemann
On Monday 12 November 2012 19:04:25 Stuart Dickson wrote: > A single library for managing EMF, SVM and WMF files. > > I have submitted commits to the branch: libs-vectorimage-stuartmd-forreview > Only the last three are relevant to the libs/vectorimage work - the diff > may be generated with the c

Re: Review Request: fix signal/slot connections for KoDocumentRdf's semanticObject* signals

2012-11-15 Thread C. Boemann
don't think we actually need to remove that, but I have removed the user visible stuff as much as I could, because we are still evolving, but mostly because we are lacking some useful/relevant user interface. - C. Boemann On Nov. 15, 2012, 10:27 a.m., Friedrich W. H. Kossebau

Re: Issues with Pivot Tables' Project

2012-11-16 Thread C. Boemann
On Friday 16 November 2012 06:20:57 jigar raisinghani wrote: > Hi, > > I had developed pivot tables as part of my gsoc project. There were a > couple of small features which i wanted to add to my project. A bit of > documentation was also left. Last week I started looking into the code. A > c

Re: Review Request: Fix saving of Author info for non-default and non-anonymous case

2012-11-18 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107366/#review22168 --- Ship it! yes please backport - C. Boemann On Nov. 18, 2012

Re: Review Request: Use for default Author profile also any existing info about emailaddress and phonenumbers

2012-11-18 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107370/#review22173 --- Ship it! yes please backport - C. Boemann On Nov. 18, 2012

Re: Review Request: metadata

2012-11-18 Thread C. Boemann
org/r/107371/#comment17083> What is the reason for this. I mean is not-trimmed important? - C. Boemann On Nov. 18, 2012, 8:14 p.m., mojtaba shahi wrote: > > --- > This is an automatically generated e-mail. To reply

Re: Review Request: metadata

2012-11-18 Thread C. Boemann
you use plain text. This needs to be fixed - C. Boemann On Nov. 18, 2012, 9:11 p.m., mojtaba shahi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: metadata

2012-11-18 Thread C. Boemann
ttp://git.reviewboard.kde.org/r/107371/#comment17086> this needs to be rfc5646 too - C. Boemann On Nov. 18, 2012, 10:29 p.m., mojtaba shahi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboar

Re: Review Request: Fix exporting to non-native formats on Windows, e.g. HTML

2012-11-19 Thread C. Boemann
org/r/107388/ > --- > > (Updated Nov. 19, 2012, 7:20 p.m.) > > > Review request for Calligra, Boudewijn Rempt and C. Boemann. > > > Description > --- > > Currently exporting to non-native formats (File/Export...) fails on Windows, > because the temporar

Re: Workspace proposal

2012-11-20 Thread C. Boemann
On Tuesday 20 November 2012 22:05:48 Sven Langkamp wrote: > Hi, > > > I have been discussing this on IRC with boemann and ingwa and to clear > things up I did write it down. > > This a proposal for a new UI for our tool docker/box UI. Proposal can > be found here: http://depot.tu-dortmund.de/get

Re: Workspace proposal

2012-11-21 Thread C. Boemann
On Wednesday 21 November 2012 02:25:12 Yuë Liu wrote: > What's the difference from Ribbon UI from users' perspective? Except > one is vertical and another is horizontal. Well both is context/mode based if that is what you mean, but our approach keep the menus for all the basic file, edit, view, se

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

2012-11-25 Thread C. Boemann
org/r/107459/ > --- > > (Updated Nov. 25, 2012, 4:44 p.m.) > > > Review request for Calligra, Arjen Hiemstra, Boudewijn Rempt, Inge Wallin, > and C. Boemann. > > > Description > --- > > This patch helps to pass the issue in the > http://build.kde.o

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-25 Thread C. Boemann
e.org/r/107445/#comment17241> is this a correct change? - C. Boemann On Nov. 24, 2012, 2:36 p.m., Pierre Stirnweiss wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-26 Thread C. Boemann
const plugins/textshape/dialogs/StylesFilteredModelBase.cpp <http://git.reviewboard.kde.org/r/107445/#comment17300> no need for this empty line plugins/textshape/dialogs/StylesFilteredModelBase.cpp <http://git.reviewboard.kde.org/r/107

Review Request: Make it possible to override info from author profile via dbus/c++

2012-11-27 Thread C. Boemann
89bcdbe Diff: http://git.reviewboard.kde.org/r/107486/diff/ Testing --- Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Review Request: Fix copy paste to include named styles

2012-11-27 Thread C. Boemann
ns of styles applied Thanks, C. Boemann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Fix copy paste to include named styles

2012-11-28 Thread C. Boemann
a new diff just for that - C. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107495/#review22682 --- On Nov. 27, 20

Re: Review Request: Sort styles according to usage in the docker's combos

2012-11-28 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107445/#review22688 --- Ship it! Great work - 2.7 will rock - C. Boemann On Nov

Re: Review Request: Fix copy paste to include named styles

2012-11-29 Thread C. Boemann
tyles/KoStyleManager.h ae2e720 libs/kotext/styles/KoStyleManager.cpp 2aa74fe Diff: http://git.reviewboard.kde.org/r/107495/diff/ Testing --- Some basic cut and paste with variations of styles applied Thanks, C. Boemann ___ calligra-devel mailing

Re: Review Request: add KoRdfSemanticItem::createSystemStylesheet(...), so 3rd-party KoRdfSemanticItem subclasses can create themselves some system stylesheets

2012-11-29 Thread C. Boemann
too - C. Boemann On Nov. 29, 2012, 6:35 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Remove unneeded loop in KoDocumentRdf::emitSemanticObjectUpdated(...)

2012-11-29 Thread C. Boemann
- C. Boemann On Nov. 28, 2012, 6:18 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Add a parent parameter to CanvasItem in sheets/part/

2012-11-29 Thread C. Boemann
> On Nov. 29, 2012, 7:15 p.m., Marijn Kruisselbrink wrote: > > Ship It! > > Philip Hoof wrote: > I have no commit access afaik, something I can do to help shipping this? some kind soul will do it for you soon enough - C. --- This i

Re: Review Request: enable 3rd-party to have semantic items with stylesheets which do not change the text at all

2012-11-30 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107534/#review22818 --- Ship it! yeah hackish, but sure let's have this - C. Bo

Re: Review Request: Fix next style appears as modified after new line on header style (bug 293378).

2012-12-01 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107540/#review22863 --- Ship it! - C. Boemann On Dec. 1, 2012, 1:29 p.m., Pierre

Re: Review Request: Fix Mobi format problems

2012-12-02 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107526/#review22914 --- Ship it! yes it HAS to be backported! - C. Boemann On Dec

Re: Review Request: Implement triple button widget

2012-12-03 Thread C. Boemann
But like Thorsten I would like to see the diff. Though I had seen an earlier diff and had comments that I know have been worked on it's always nice to see the final diff. - C. Boemann On Dec. 3, 2012, 12:41 a.m., Jean-Nicol

Re: Review Request: Avoid compiler warning in Global.h for external projects using Sheets' components

2012-12-04 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107580/#review22979 --- Ship it! Ship It! - C. Boemann On Dec. 4, 2012, 2:47 p.m

Re: Review Request: fix saving of textranges in KoTextWriter::Private::saveParagraph(...)

2012-12-06 Thread C. Boemann
ttp://git.reviewboard.kde.org/r/107601/#comment17630> I don't like how this has been removed. I think we risk losing some text here. Though i guess that is what the above line dividers.append(spanTo); accomplishes. If so I think a comment is in order. - C. Boemann

Re: Review Request: fix saving of textranges in KoTextWriter::Private::saveParagraph(...)

2012-12-06 Thread C. Boemann
. I'm satisfied so unless you still have some outstanding issues I think we should ship it - and to 2.6 too for sure - C. Boemann On Dec. 6, 2012, 2:45 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically ge

Re: Review Request: remove partially disabled debug output for text ranges which can result in crashes

2012-12-06 Thread C. Boemann
fixes without a request. It's quite obvious it's a bug - C. Boemann On Dec. 6, 2012, 6:10 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git

Re: Review Request: Implement triple button widget

2012-12-06 Thread C. Boemann
;m in support of inclusion when you are satisfied with the code :) - C. Boemann On Dec. 6, 2012, 5:17 p.m., Jean-Nicolas Artaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: fix KoDocumentRdf::findXmlId(KoTextEditor *) to find the correct xmlId

2012-12-06 Thread C. Boemann
, and although you ae right it doesn't find the closest I also think it a broken idea to find the closest - C. Boemann On Dec. 6, 2012, 8:37 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-ma

Re: Review Request: fix KoDocumentRdf::findXmlId(KoTextEditor *) to find the correct xmlId

2012-12-06 Thread C. Boemann
is that you can have all sorts of overlappping ranges, and in tables such ranges are even weirder (what is numerically within is not within at all). The concept is thus broken. It's not possible to really find a true solution. The current code is wrong too ofcourse - C. Boemann On D

Re: Review Request: Fix applying paragraphStyle

2012-12-06 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107616/#review23107 --- Ship it! Ship It! - C. Boemann On Dec. 6, 2012, 6:54 p.m

Review Request: make sure we don't find more textranges than we ask for

2012-12-06 Thread C. Boemann
Diff: http://git.reviewboard.kde.org/r/107621/diff/ Testing --- None, except the skf test case, and some debug utput to see the method actually does what I want it to. However there may be some regressions (espcialy in saving), because of changed behavour Thanks,

Re: Review Request: fix KoDocumentRdf::findXmlId(KoTextEditor *) to find the correct xmlId

2012-12-06 Thread C. Boemann
nyway this is a definite decline of the review request. Please close. But let's discuss on irc what to do with the implementation and/or api and/or apidox and then either fix or open a bug about it. It's too broken to be just forgotten again. - C. Boemann On Dec. 6, 2012, 8:37 p.m.,

Re: Review Request: Implement triple button widget

2012-12-07 Thread C. Boemann
> On Dec. 6, 2012, 11:01 p.m., C. Boemann wrote: > > Ok jaroslaw you take the review process from here - I'm in support of > > inclusion when you are satisfied with the code :) > > Jarosław Staniek wrote: > So I'll try to test the widget with various

Review Request: change suffix to .html

2012-12-07 Thread C. Boemann
suffix to .html as that is what people expect rather than .xhtml ok to backport? Diffs - filters/words/epub/OdtHtmlConverter.cpp 3c12165 Diff: http://git.reviewboard.kde.org/r/107631/diff/ Testing --- Thanks, C. Boemann ___ calligra

Re: Review Request: change suffix to .html

2012-12-08 Thread C. Boemann
she enters in the filedialog :) Totally fair argument, and I agree. Ok I'll drop this request :) - C. --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107631/#review23150 --- On Dec. 8, 2012

Re: PierreSt's style sorting code in 2.6?

2012-12-09 Thread C. Boemann
On Saturday 08 December 2012 18:05:03 Inge Wallin wrote: > Piere Stirnweiss has done some very nice work on presenting the styles in > the order with the used ones sorted first. This is now in master and it is > one of the most asked-for features from real users. Or put another way: > not having th

Re: Review Request: Move the Create Path tool from flake/tools to plugins/defaulttools

2012-12-11 Thread C. Boemann
reviewboard.kde.org/r/107671/#comment17943> To possible other reviewers. I said this was okay, we are going to move the snap option widgets out into a docker (as per ui design discussions at Akademy) - C. Boemann On Dec. 11, 2012, 10:29 p.m., Jea

Re: Review Request: Move the Create Path tool from flake/tools to plugins/defaulttools

2012-12-13 Thread C. Boemann
> On Dec. 11, 2012, 10:35 p.m., C. Boemann wrote: > > plugins/defaultTools/createPathTool/KoCreatePathTool.cpp, line 373 > > <http://git.reviewboard.kde.org/r/107671/diff/1/?file=98368#file98368line373> > > > > To possible other reviewers. > > >

Re: Review Request: Add a parent parameter to CanvasItem in sheets/part/

2012-12-16 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107514/#review23529 --- Phillip could you please close this as submitted, thanks - C

Re: Review Request: Fix crash in Words for multipage documents

2012-12-16 Thread C. Boemann
way - C. Boemann On Sept. 1, 2012, 11:01 a.m., Gopalakrishna Bhat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Snap Guide in the dockers.

2012-12-17 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107785/#review23614 --- Ship it! Ship It! - C. Boemann On Dec. 17, 2012, 3:10 p.m

Re: Review Request: Move the Create Path tool from flake/tools to plugins/defaulttools

2012-12-18 Thread C. Boemann
for some of it's tools we have a problem - C. Boemann On Dec. 18, 2012, 9:27 a.m., Jean-Nicolas Artaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: [calligra] /: Move the external library kdchart from the chart shape to 3rdparty/.

2012-12-18 Thread C. Boemann
On Tuesday 18 December 2012 19:42:13 Thorsten Zachmann wrote: > On Tuesday 18 December 2012 19:29:39 Inge Wallin wrote: > > On Sunday, December 16, 2012 17:02:40 Inge Wallin wrote: > > > Git commit 3dbbc7afa43e548177eabea821ccdc18bd982566 by Inge Wallin. > > > Committed on 16/12/2012 at 16:50. > >

Re: [calligra] /: Move the external library kdchart from the chart shape to 3rdparty/.

2012-12-18 Thread C. Boemann
On Tuesday 18 December 2012 23:04:31 Inge Wallin wrote: > On Tuesday, December 18, 2012 20:05:28 C. Boemann wrote: > > On Tuesday 18 December 2012 19:42:13 Thorsten Zachmann wrote: > > > On Tuesday 18 December 2012 19:29:39 Inge Wallin wrote: > > > > On Sunday, D

a new library

2012-12-18 Thread C. Boemann
at are too important or generic enough that we can't have them in plugins but need to be sure is available. For now it would only contain the KoCreatePathTool but in the past I've thought that maybe the textshape needs to be in a library instead of a plugin. So what do you say? bes

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 10:03:24 Boudewijn Rempt wrote: > On Wednesday 19 December 2012 Dec, C. Boemann wrote: > > Hi > > > > In an attempt to to rework the ui, we have run into a problem: > > > > KoCreatePathTool in libs/flake needs some widgets from

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 11:36:36 Jaroslaw Staniek wrote: > On 19 December 2012 10:41, Inge Wallin wrote: > > All this said, I think a refactor could be a good idea. But why not make > > a meaningful name? libflaketools should be obvious enough; alpine is > > justa bit too clever for me. >

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > On 19 December 2012 12:59, C. Boemann wrote: > > Yes i'm not attached to alpine in any way. I couldn't come up with a > > generic name that describes the library very well ( and no flaketools > > doe

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 13:26:33 Jaroslaw Staniek wrote: > On 19 December 2012 13:19, C. Boemann wrote: > > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > >> On 19 December 2012 12:59, C. Boemann wrote: > >> > Yes i'm not attached to al

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 13:40:46 Pierre Stirnweiss wrote: > On Wed, Dec 19, 2012 at 1:19 PM, C. Boemann wrote: > > On Wednesday 19 December 2012 13:11:51 Jaroslaw Staniek wrote: > > > On 19 December 2012 12:59, C. Boemann wrote: > > > > Yes i'm not attach

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 14:42:33 Boudewijn Rempt wrote: > On Wednesday 19 December 2012 Dec, C. Boemann wrote: > > On Wednesday 19 December 2012 13:26:33 Jaroslaw Staniek wrote: > > > On 19 December 2012 13:19, C. Boemann wrote: > > > > On Wednesday 19 D

Re: a new library

2012-12-19 Thread C. Boemann
On Wednesday 19 December 2012 10:41:42 Inge Wallin wrote: > On Wednesday, December 19, 2012 01:55:38 C. Boemann wrote: > > Hi > > > > In an attempt to to rework the ui, we have run into a problem: > > > > KoCreatePathTool in libs/flake needs some widgets from

Re: Review Request: Implement triple button widget

2012-12-20 Thread C. Boemann
On Dec. 18, 2012, 2:46 p.m., Jean-Nicolas Artaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107530/ > ---

Re: Review Request: Fix clicking in selection does not update caret

2012-12-22 Thread C. Boemann
initializers to: , m_sometihng(xx) rather than the other way and ok to backport - C. Boemann On Dec. 22, 2012, 4:47 p.m., Pierre Stirnweiss wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request: Introduce kowidgetutils library and put KoGroupButton in it

2012-12-22 Thread C. Boemann
name, but we can always change that. I'm probably also going to make a review request for the proposal i had for drawing. - C. Boemann On Dec. 21, 2012, 11:16 p.m., Jarosław Staniek wrote: > > --- > This is an automatical

Re: Review Request: Implement triple button widget

2012-12-22 Thread C. Boemann
uest which builds on top of yours I think we can close your request, as refused. That said I want to say thanks for the great work you did on this. - C. Boemann On Dec. 22, 2012, 4:07 p.m., Jean-Nicolas Artaud wrote: > >

Re: Review Request: Fix apply characterStyle to a caret without selection

2012-12-23 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107878/#review23917 --- Ship it! yes, good work, please backport - C. Boemann On

Review Request: basicflakes library

2012-12-28 Thread C. Boemann
f14139c libs/flake/tools/KoCreatePathTool_p.h 3bdedd7 Diff: http://git.reviewboard.kde.org/r/107979/diff/ Testing --- Have reinstalled from scratch and seen that the tools are still there and works. Thanks, C. Boemann ___ calligra-devel

Re: Review Request: Make the epub filter handle math formulas

2012-12-28 Thread C. Boemann
where there is no {} after if other than that I've not looked yet - I assume you want moji to review - C. Boemann On Dec. 28, 2012, 2:48 a.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request: Use const-ref in foreach where possible

2012-12-28 Thread C. Boemann
nough to me. - C. Boemann On Dec. 28, 2012, 8:02 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

<    3   4   5   6   7   8   9   10   11   >