----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107445/#review22611 -----------------------------------------------------------
I've noted several issues, but all in all I'm close to saying it's good libs/kotext/styles/KoCharacterStyle.h <http://git.reviewboard.kde.org/r/107445/#comment17287> let's not have implementaion in header file libs/kotext/styles/KoCharacterStyle.h <http://git.reviewboard.kde.org/r/107445/#comment17288> spaces around = libs/kotext/styles/KoCharacterStyle.h <http://git.reviewboard.kde.org/r/107445/#comment17289> const libs/kotext/styles/KoParagraphStyle.h <http://git.reviewboard.kde.org/r/107445/#comment17290> no impl in header file please libs/kotext/styles/KoParagraphStyle.h <http://git.reviewboard.kde.org/r/107445/#comment17291> const libs/kotext/styles/KoStyleManager.cpp <http://git.reviewboard.kde.org/r/107445/#comment17292> these shuld be const too plugins/textshape/CMakeLists.txt <http://git.reviewboard.kde.org/r/107445/#comment17293> should we remove these completely or are they also leftover? plugins/textshape/TextTool.cpp <http://git.reviewboard.kde.org/r/107445/#comment17294> hmm why this plugins/textshape/dialogs/AbstractStylesModel.h <http://git.reviewboard.kde.org/r/107445/#comment17295> const plugins/textshape/dialogs/DockerStylesComboModel.cpp <http://git.reviewboard.kde.org/r/107445/#comment17296> should we maybe have an enum for this rather than hardcoded value plugins/textshape/dialogs/DockerStylesComboModel.cpp <http://git.reviewboard.kde.org/r/107445/#comment17297> isn't !empty() faster? plugins/textshape/dialogs/StylesCombo.cpp <http://git.reviewboard.kde.org/r/107445/#comment17298> really? plugins/textshape/dialogs/StylesFilteredModelBase.h <http://git.reviewboard.kde.org/r/107445/#comment17299> const plugins/textshape/dialogs/StylesFilteredModelBase.cpp <http://git.reviewboard.kde.org/r/107445/#comment17300> no need for this empty line plugins/textshape/dialogs/StylesFilteredModelBase.cpp <http://git.reviewboard.kde.org/r/107445/#comment17301> or this empty line - C. Boemann On Nov. 26, 2012, 9:27 p.m., Pierre Stirnweiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107445/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2012, 9:27 p.m.) > > > Review request for Calligra, Inge Wallin and C. Boemann. > > > Description > ------- > > This introduces sorting of the styles in the combos according to usage. > This is a first step into revamping the styles handling. > > > Diffs > ----- > > libs/kotext/KoTextEditor.h 64f47bb > libs/kotext/KoTextEditor_format.cpp 8985fcc > libs/kotext/styles/KoCharacterStyle.h 765f49e > libs/kotext/styles/KoCharacterStyle.cpp fcb20fd > libs/kotext/styles/KoParagraphStyle.h 7ee1787 > libs/kotext/styles/KoParagraphStyle.cpp f8bffb6 > libs/kotext/styles/KoStyleManager.h ae2e720 > libs/kotext/styles/KoStyleManager.cpp 2aa74fe > plugins/textshape/CMakeLists.txt 6253323 > plugins/textshape/TextTool.cpp 207dfd9 > plugins/textshape/dialogs/AbstractStylesModel.h PRE-CREATION > plugins/textshape/dialogs/AbstractStylesModel.cpp PRE-CREATION > plugins/textshape/dialogs/DockerStylesComboModel.h PRE-CREATION > plugins/textshape/dialogs/DockerStylesComboModel.cpp PRE-CREATION > plugins/textshape/dialogs/SimpleCharacterWidget.h d14007c > plugins/textshape/dialogs/SimpleCharacterWidget.cpp a7feb89 > plugins/textshape/dialogs/SimpleParagraphWidget.h a7d7f52 > plugins/textshape/dialogs/SimpleParagraphWidget.cpp 6fd2f67 > plugins/textshape/dialogs/StylesCombo.h 484b8fc > plugins/textshape/dialogs/StylesCombo.cpp a5e7172 > plugins/textshape/dialogs/StylesFilteredModelBase.h PRE-CREATION > plugins/textshape/dialogs/StylesFilteredModelBase.cpp PRE-CREATION > plugins/textshape/dialogs/StylesModel.h 7096d53 > plugins/textshape/dialogs/StylesModel.cpp 64767f8 > plugins/textshape/dialogs/ValidParentStylesProxyModel.h PRE-CREATION > plugins/textshape/dialogs/ValidParentStylesProxyModel.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/107445/diff/ > > > Testing > ------- > > Playing around with it did not show regressions with current state of the > affair. There are a couple of glitches in handling styles, but these are also > present in the current build. > > > Thanks, > > Pierre Stirnweiss > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
