----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107088/#review21041 -----------------------------------------------------------
libs/kotext/KoAnnotation.h <http://git.reviewboard.kde.org/r/107088/#comment16539> these two methods have been romoved from kotextrange libs/kotext/KoTextInlineRdf.cpp <http://git.reviewboard.kde.org/r/107088/#comment16540> No we don't so you can safely remove the comment libs/kotext/KoTextInlineRdf.cpp <http://git.reviewboard.kde.org/r/107088/#comment16541> nope libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/107088/#comment16542> hmm a bit wasteful of cycles libs/kotext/opendocument/KoTextLoader.cpp <http://git.reviewboard.kde.org/r/107088/#comment16543> So you are basically handling annotation and annotation-start in one go? It doesn't seem completely safe to me but oh well libs/widgets/CMakeLists.txt <http://git.reviewboard.kde.org/r/107088/#comment16544> more trailing space - C. Boemann On Oct. 28, 2012, 2:47 a.m., Inge Wallin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107088/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2012, 2:47 a.m.) > > > Review request for Calligra. > > > Description > ------- > > I really wanted to have annotations for 2.6. But this patch at least brings > loading, storing and saving of annotations even if they cannot yet be be > created or edited or even shown. > > The patch contained some parts that had to do with the view in Words but I > disabled that. It's easy to remove if necessary. > > For reasons you can read on the mailing list I would really like to get this > patch into 2.6. > > > Diffs > ----- > > libs/kotext/CMakeLists.txt 28faa22 > libs/kotext/KoAnnotation.h PRE-CREATION > libs/kotext/KoAnnotation.cpp PRE-CREATION > libs/kotext/KoAnnotationManager.h PRE-CREATION > libs/kotext/KoAnnotationManager.cpp PRE-CREATION > libs/kotext/KoTextInlineRdf.h 91dbccd > libs/kotext/KoTextInlineRdf.cpp 1017cf4 > libs/kotext/KoTextRangeManager.h fc6fb95 > libs/kotext/KoTextRangeManager.cpp 5417be8 > libs/kotext/opendocument/KoTextLoader.cpp 5cf9543 > libs/widgets/CMakeLists.txt 61df2d6 > libs/widgets/KoAnnotationBalloon.h PRE-CREATION > libs/widgets/KoAnnotationBalloon.cpp PRE-CREATION > libs/widgets/KoAnnotationSideBar.h PRE-CREATION > libs/widgets/KoAnnotationSideBar.cpp PRE-CREATION > libs/widgets/KoBalloon.h PRE-CREATION > libs/widgets/KoBalloon.cpp PRE-CREATION > words/part/KWCanvas.cpp 08060d2 > words/part/KWCanvasBase.cpp e74835e > words/part/KWCanvasItem.cpp dd90755 > words/part/KWView.cpp b1004ed > words/part/tests/CMakeLists.txt 9fa7787 > > Diff: http://git.reviewboard.kde.org/r/107088/diff/ > > > Testing > ------- > > Test file created by LibreOffice. > > > Thanks, > > Inge Wallin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
