> On Oct. 18, 2012, 9:43 p.m., C. Boemann wrote: > > libs/main/KoDocument.cpp, line 660 > > <http://git.reviewboard.kde.org/r/106941/diff/1/?file=91059#file91059line660> > > > > uhm it should be written by saveOasisPreview no? > > > > I think I removed this not that many weeks / months ago (not sure) > > can't recall why, but i don't feel confident approving this just yet
hmm no i didn't since the comment was by boudewijn - C. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106941/#review20562 ----------------------------------------------------------- On Oct. 18, 2012, 10:41 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106941/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2012, 10:41 a.m.) > > > Review request for Calligra. > > > Description > ------- > > For some undocumented reason there is no entry written for the thumbnail file. > > I could not see a reason why this is not done. In opposite, > http://odf-validator2.rhcloud.com/odf-validator2/ complained about this > missing entry. And files from LO always have this manifest entry. > > Okay to also backport to 2.5 branch? > > > Diffs > ----- > > libs/main/KoDocument.cpp dac99c7 > > Diff: http://git.reviewboard.kde.org/r/106941/diff/ > > > Testing > ------- > > LO 3.5 loaded the file fine, roundtrips with Calligra Words also are fine. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
