-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107621/
-----------------------------------------------------------
Review request for Calligra and Friedrich W. H. Kossebau.
Description
-------
Make the textRangesChangingWithin method actually check all that it's supposed
to check
Normally we don't use this method in a too complex way so there should be no
regressions,
but still if bugs come up with saving too few textranges, this will be a patch
to investigate
Basically we were only checking the matching tag against one of the parameters
while we should be
checking against both. I most case the our use is to have global match limits,
so that is why we
have not noticed the bug.
Diffs
-----
libs/kotext/KoTextRangeManager.cpp 0940fda
Diff: http://git.reviewboard.kde.org/r/107621/diff/
Testing
-------
None, except the skf test case, and some debug utput to see the method actually
does what I want it to.
However there may be some regressions (espcialy in saving), because of changed
behavour
Thanks,
C. Boemann
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
