----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107842/#review23855 -----------------------------------------------------------
Ship it! Looks good enough for me. Not sure about the library name, but we can always change that. I'm probably also going to make a review request for the proposal i had for drawing. - C. Boemann On Dec. 21, 2012, 11:16 p.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107842/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2012, 11:16 p.m.) > > > Review request for Calligra, Jean-Nicolas Artaud, Adam Pigg, Dimitrios Tanis, > Radosław Wicik, and Oleg Kukharchuk. > > > Description > ------- > > Introduce kowidgetutils library to Calligra libs 2.7 and put KoGroupButton in > it. > > The KoGroupButton's code is untouched (except for the EXPORT name) and comes > from Jean-Nicolas Artaud - see https://git.reviewboard.kde.org/r/107530 so > please do not report issues related to it here. In that patch KoGroupButton > was put into kowidgets library what's suboptimal because of dependencies - no > point to depend on kotext, etc. to use one unrelated widget. > > This change is s small step to increase modularity. > > More classes to come here, including improvements to KoGroupButton. > > > Diffs > ----- > > libs/CMakeLists.txt 531873f7e8fb3c8f1f7f49d3d355e9f6e537ac2b > libs/widgetutils/CMakeLists.txt PRE-CREATION > libs/widgetutils/KoGroupButton.h PRE-CREATION > libs/widgetutils/KoGroupButton.cpp PRE-CREATION > libs/widgetutils/README PRE-CREATION > libs/widgetutils/kowidgetutils_export.h PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/107842/diff/ > > > Testing > ------- > > Tested in Kexi > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
