----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107205/#review21881 -----------------------------------------------------------
Ship it! good enough for master - C. Boemann On Nov. 5, 2012, 7:52 a.m., Dmitry Kazakov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107205/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2012, 7:52 a.m.) > > > Review request for Calligra. > > > Description > ------- > > Fixed deactivation of the tools when input device is switched > > There are lots of things that have to be done when we switch current > canvasData object. That is why I moved all these actions into > switchCanvasData object. The old tool first becomes disconnected from the > tool manager, then the canvasData is switched and a new tool is connected. > > This patch fixes several bugs when the tools was not deactivated properly > when the input device was switched, so their hotkeys were kept activated. > More than that, this fix is needed to be able to solve bug 298584 properly. > > > Diffs > ----- > > libs/flake/KoToolManager.cpp c121d0f > libs/flake/KoToolManager_p.h 85985df > > Diff: http://git.reviewboard.kde.org/r/107205/diff/ > > > Testing > ------- > > Tested in Krita and Karbon. > > > Thanks, > > Dmitry Kazakov > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
