----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107671/#review23334 -----------------------------------------------------------
All i all I like it, but I'm respectfully awaiting other reviewers Should we rename the tool to not start with Ko now that it's not part of libs anymore plugins/defaultTools/CMakeLists.txt <http://git.reviewboard.kde.org/r/107671/#comment17942> no space please plugins/defaultTools/createPathTool/KoCreatePathTool.cpp <http://git.reviewboard.kde.org/r/107671/#comment17943> To possible other reviewers. I said this was okay, we are going to move the snap option widgets out into a docker (as per ui design discussions at Akademy) - C. Boemann On Dec. 11, 2012, 10:29 p.m., Jean-Nicolas Artaud wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107671/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2012, 10:29 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Move the Create Path tool from flake/tools to plugins/defaulttools > > With Boemann we plan to make this tool load the stroke config widget. That's > why we need it in the plug-ins and for now it's not used in the flake. > > > Diffs > ----- > > libs/flake/CMakeLists.txt 62bc2dc > libs/flake/KoToolRegistry.cpp 0ceb40e > plugins/defaultTools/CMakeLists.txt 1f16010 > plugins/defaultTools/Plugin.cpp f811418 > plugins/defaultTools/createPathTool/KoCreatePathTool.h 5b0ae7e > plugins/defaultTools/createPathTool/KoCreatePathTool.cpp 8dfbe34 > plugins/defaultTools/createPathTool/KoCreatePathToolFactory.h 1db235e > plugins/defaultTools/createPathTool/KoCreatePathToolFactory.cpp f14139c > > Diff: http://git.reviewboard.kde.org/r/107671/diff/ > > > Testing > ------- > > Tool tested after the move on the branch flake-movetools-morice. > > > Thanks, > > Jean-Nicolas Artaud > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
