Re: KWPageManager::pages question

2015-12-05 Thread Thorsten Zachmann
On Saturday, December 05, 2015 02:24:43 PM Friedrich W. H. Kossebau wrote: > Hi Thorsten, > > Am Samstag, 5. Dezember 2015, 06:24:11 schrieb Thorsten Zachmann: > [snip] > > > Is it ok to add that or is the comment wrong and I could use the sort > > inside cstester. I d

KWPageManager::pages question

2015-12-04 Thread Thorsten Zachmann
Hello, when working on getting cstester ported I noticed that the pages are in a random oder all the time. Looking at the code I see that the pages are stored in q QHash and it seems that at least in Qt5 the order is not always the same in every run. In the header it is says that the pages a

Re: Review Request 125493: PictureShapeConfigWidget: add error handling to KIO::Job.

2015-10-05 Thread Thorsten Zachmann
On 2015-10-05 12:44, David Faure wrote: On Monday 05 October 2015 10:30:04 Boudewijn Rempt wrote: Sorry, was waiting for Zagge. No problem. Please note that these are waiting for review too: REVIEW: 125490 this one already has a ship it REVIEW: 125489 Here I had not noticed that

Re: Review Request 125510: Add KPrShapeAnimations::dump() for debugging the animation tree.

2015-10-04 Thread Thorsten Zachmann
- > > (Updated Oct. 3, 2015, 6:15 p.m.) > > > Review request for Calligra and Thorsten Zachmann. > > > Repository: calligra > > > Description > --- > > Add KPrShapeAnimations::dump() for debugging the animation tree. >

Re: Many questions for Stage

2015-10-04 Thread Thorsten Zachmann
Hello David, On Friday, October 02, 2015 09:54:59 AM David Faure wrote: > Here are some questions to ensure I won't change behavior that was there on > purpose, or that I didn't miss something obvious: > > * Shape animations: Move up / Move down doesn't move the setting "start on > mouse click /

Re: Review Request 125489: Cleanup KActionMenu usage: activated() is never emitted, member var not needed.

2015-10-02 Thread Thorsten Zachmann
Start Presentation button without extending the submenu. - Thorsten Zachmann On Oct. 2, 2015, 9:09 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125488: Avoid hitting assert in QPainter when CropWidget tries to paint a null image rect.

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125488/#review86273 --- Ship it! Ship It! - Thorsten Zachmann On Oct. 2, 2015, 9

Re: Review Request 125490: Make Esc stop the presentation also in the main view.

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125490/#review86272 --- Ship it! Ship It! - Thorsten Zachmann On Oct. 2, 2015, 9

Re: Review Request 125491: Fix crash when exiting Stage and the presentation mode is still on

2015-10-02 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125491/#review86271 --- Ship it! Ship It! - Thorsten Zachmann On Oct. 2, 2015, 9

Re: Review Request 125492: Remove AnimationTmpData struct, take two pointers for output values instead.

2015-10-02 Thread Thorsten Zachmann
patch. Boudewijn can you please forward port the patch. - Thorsten Zachmann On Oct. 2, 2015, 9:16 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125494: PictureShapeConfigWidget: ensure we only select existing files.

2015-10-02 Thread Thorsten Zachmann
. Boudewijn can you please forward port the fixes. - Thorsten Zachmann On Oct. 2, 2015, 9:23 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125495: Fix empty animation steps when removing animations.

2015-10-02 Thread Thorsten Zachmann
. Boudewijn can you please port forward. - Thorsten Zachmann On Oct. 2, 2015, 9:25 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Many fixes for Stage

2015-10-02 Thread Thorsten Zachmann
Hello David, On 2015-10-02 09:52, David Faure wrote: I used Stage to make a presentation yesterday, and I have many bugfixes to submit (and then some questions, and some bug reports). I just pushed the trivial fixes (typos and cleanups), but how do you want the patches for the more substantial

Re: Review Request 124291: Loop optimalization at table cell formatting

2015-07-15 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124291/#review82560 --- Ship it! Looks good please commit. - Thorsten Zachmann On

[Differential] [Commented On] D128: Restore loading of defaultstyles.xml

2015-06-27 Thread zachmann (Thorsten Zachmann)
zachmann added a subscriber: zachmann. zachmann added a comment. The patch looks good for me. Thanks for the nice description. REPOSITORY rCALLIGRA Calligra REVISION DETAIL https://phabricator.kde.org/D128 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To

Re: Review Request 123955: get calligra frameworks to compile with qt 5.5 by including needed headers

2015-05-30 Thread Thorsten Zachmann
Just remove it if it no longer works. libs/flake/KoPathShape.cpp (line 54) <https://git.reviewboard.kde.org/r/123955/#comment55472> Don't comment out code. Just remove it if it no longer works. - Thorsten Zachmann On May 30, 2015, 11:04 p.m.,

Re: Review Request 123660: Improve KoFindToolbar

2015-05-06 Thread Thorsten Zachmann
marked as submitted. Review request for Calligra. Changes --- Submitted with commit 1f26d5d084f608ada048b66edb3ce6e949e4f5cb by Thorsten Zachmann to branch calligra/2.9. Repository: calligra Description --- The KoFindToolbar is used in words to search the documents. The current

Review Request 123660: Improve KoFindToolbar

2015-05-06 Thread Thorsten Zachmann
ca12462 libs/main/KoFindToolbar_p.h 54ecaf5 Diff: https://git.reviewboard.kde.org/r/123660/diff/ Testing --- Tested interactive searching. Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https

Re: 2.9.3 reminder

2015-04-25 Thread Thorsten Zachmann
On Friday, April 24, 2015 11:04:30 PM Jaroslaw Staniek wrote: > We need changelogs, please... > Stage: Fix crash after empty custom slide show. 34cfe3dc353669d1f167f6df91ae14d6e6785224 Stage / Flow: Fix showing of thumbnail after updating master page 8784da05a5d76fc9bc4a10220d87fee77ecb018c f53

Re: Review Request 123440: Load defaults markers.xml directly via "data" resource dirs, not "styles"

2015-04-23 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123440/#review79405 --- Ship it! Looks good. - Thorsten Zachmann On April 20

Re: Review Request 123352: Fix DockerStylesComboModel

2015-04-16 Thread Thorsten Zachmann
/StylesModel.h d15651f plugins/textshape/dialogs/StylesModel.cpp f996824 Diff: https://git.reviewboard.kde.org/r/123352/diff/ Testing --- Tested adding of various style with different names. Worked quite nicly Thanks, Thorsten Zachmann

Re: Review Request 123352: Fix DockerStylesComboModel

2015-04-15 Thread Thorsten Zachmann
://git.reviewboard.kde.org/r/123352/diff/ Testing --- Tested adding of various style with different names. Worked quite nicly Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra

Re: Review Request 123352: Fix DockerStylesComboModel

2015-04-15 Thread Thorsten Zachmann
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123352/#review79010 --- On April 13, 2015, 2:01 p.m., Thorsten Zachmann wrote: > > -

Review Request 123352: Fix DockerStylesComboModel

2015-04-13 Thread Thorsten Zachmann
Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 123146: calligra sheets: do not use VerPattern twice for cell pattern

2015-03-26 Thread Thorsten Zachmann
that the solid one in just before the no brush pattern. - Thorsten Zachmann On March 27, 2015, 3:27 a.m., Boris Egorov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: How to modify or create my own slide layouts in Stage?

2015-03-22 Thread Thorsten Zachmann
Hello Henrik, On Friday, March 20, 2015 12:07:48 PM Henrik Ingo wrote: > First, I'd like to congratulate the Calligra developers for getting > this far with a promising (and actively developed!) open source office > suite! Thanks a lot for you kind words. > It seems you are right now in that ago

Re: Review Request 122867: Replace deprecated strstream classes with sstreams in Quattro Pro filter

2015-03-09 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122867/#review77243 --- Ship it! The patch looks good to me. - Thorsten Zachmann

Re: RFC: plan for starting the Qt5/KF5 port

2015-02-27 Thread Thorsten Zachmann
Hello, > > I say it should be done now, and be done to 2.9 too > > And I almost don't think maintainers should be able to say no. The long term > goal of having a clean codebase is more important than short term issue > with git blame (have a separate permanent checkout before this revision > wh

Re: Review Request 122584: Use shared pointers for markers.

2015-02-15 Thread Thorsten Zachmann
ckout. But this does not solve the real problem. And that is that the collection is deleted before the shapes are deleted. I guess if you fix it like that we will have quite some other places too where it can crash as the collection is deleted to early. Otherwise the patch looks ok. - Tho

Re: Review Request 122266: split KWRootAreaProvider into 3 classes for better overview and solving text flwing between textboxes

2015-01-26 Thread Thorsten Zachmann
ld be {} around single line while words/part/KWRootAreaProviderTextBox.cpp <https://git.reviewboard.kde.org/r/122266/#comment51846> There should be {} around single line if. - Thorsten Zachmann On Jan. 26, 2015, 11:17 p.m., Camilla Boemann wrote: > > -

Re: KoPathShape saveOdf and loadOdf oddities

2015-01-17 Thread Thorsten Zachmann
Hello Stefano, > Hello, we have a problem in Krita with drawing a polygon or a bezier curve > (or basicly anything that uses KoPathShape) in a vector layer, then > transform it so that the lines increase their thickness, then save the file > in .kra format and then reload it: the thickness is not

Re: Review Request 121733: Fix crash reported in bug 342222

2014-12-30 Thread Thorsten Zachmann
://git.reviewboard.kde.org/r/121733/diff/ Testing --- Opened a .kra file with a text shape and pasted text to it. Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 121733: Fix crash reported in bug 342222

2014-12-29 Thread Thorsten Zachmann
00a1e68 Diff: https://git.reviewboard.kde.org/r/121733/diff/ Testing --- Opened a .kra file with a text shape and pasted text to it. Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman

Review Request 121733: Fix crash reported in bug 342222

2014-12-28 Thread Thorsten Zachmann
pasted text to it. Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Calligra Maintainers - status updated - more applications about to be freezed

2014-12-15 Thread Thorsten Zachmann
On Monday, December 15, 2014 02:01:03 PM Friedrich W. H. Kossebau wrote: > Stage has my interest from ODF point of view, I really would like some > Qt/KF- based modules for ODP. And Stage itself is also used inside Calligra > Gemini, so Leinir surely also will do some care/enhancement bits there. S

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-11-07 Thread Thorsten Zachmann
sensible to me. - Thorsten Zachmann On Nov. 4, 2014, 3:51 p.m., Dan Leinir Turthra Jensen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 120890: Supporting changes for Calligra Gemini

2014-10-31 Thread Thorsten Zachmann
uick/CQTextDocumentCanvas.cpp <https://git.reviewboard.kde.org/r/120890/#comment48781> Please move the { up to the end of the previous line qtquick/CQTextToCModel.cpp <https://git.reviewboard.kde.org/r/120890/#comment48782>

Re: Review Request 119138: Fix Bug 334832

2014-10-15 Thread Thorsten Zachmann
/ Testing --- Tested with the method to provoke the crash attached to the bugreport. Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 120342: Give Stage- and KoPA-specific tools own service types (fixes crash in Braindump and for me Flow)

2014-09-26 Thread Thorsten Zachmann
plugins in the constructor and not in componentData as it was done before? As now there is the need for another variable. - Thorsten Zachmann On Sept. 24, 2014, 9:24 p.m., Friedrich W. H. Kossebau wrote: > > --- > This is an auto

Re: Review Request 120011: Let Ctrl+Home/Ctrl+End go to top and bottom of text shape in stage.

2014-09-03 Thread Thorsten Zachmann
. Thanks for the patch. - Thorsten Zachmann On Aug. 30, 2014, 9:10 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 120010: Allow to exit text-edit mode by pressing Escape.

2014-08-30 Thread Thorsten Zachmann
. - Thorsten Zachmann On Aug. 30, 2014, 9:03 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 119138: Fix Bug 334832

2014-07-05 Thread Thorsten Zachmann
, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Style objects for applications and filters

2014-05-03 Thread Thorsten Zachmann
On Monday, April 28, 2014 10:31:45 PM Inge Wallin wrote: > * Represent styles as text attributes wherever possible so that they can be > complete, i.e. not throw away style data. I'm not conviced that this is a good idea. We tried to do that with the KoUnavailShape to prevent what we can't save

Re: Style objects for applications and filters

2014-04-26 Thread Thorsten Zachmann
On Friday, April 25, 2014 12:50:15 PM Inge Wallin wrote: > I would like to have the opinion of the community for a certain issue. The > first version of the docx export filter is now merged and it's time to take > the next step. But this next step involves a decision which needs the input > from th

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-20 Thread Thorsten Zachmann
/KoEncryptedStore.cpp <https://git.reviewboard.kde.org/r/117626/#comment39145> This should also move to the if above or isn't the default ot use DeflateCompression - Thorsten Zachmann On April 20, 2014, 8:11 a.m., Inge Wallin wrote: > >

Re: Review Request 117626: Implement the first version of a DOCX export filter

2014-04-18 Thread Thorsten Zachmann
instead of adding it to every constructor. Much less code change and only need to be called when needed. libs/odf/KoEncryptedStore.cpp <https://git.reviewboard.kde.org/r/117626/#comment39113> the unsetting/setting of the compression does not need to be done when no mimetype file is wr

Re: Review Request 116915: Fix Bug 305618

2014-03-26 Thread Thorsten Zachmann
. Good work. Please mark the review request as submitted. - Thorsten Zachmann On March 26, 2014, 5:53 a.m., Wenchao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 116915: Fix Bug 305618

2014-03-22 Thread Thorsten Zachmann
rd.kde.org/r/116915/#comment37712> A small stype issue. There should be no space before (. There should be also no space after ( and before ). I know the code you are in has quite a lot of those but it dates back to a time were we did not yet use the code style. - Thorsten Zachmann On

Re: Review Request 116915: Fix Bug 305618

2014-03-20 Thread Thorsten Zachmann
o that there is only one undo command created. - Thorsten Zachmann On March 20, 2014, 11:42 a.m., Wenchao Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 116662: Navigator docker for Words

2014-03-10 Thread Thorsten Zachmann
/KWNavigationWidget.cpp <https://git.reviewboard.kde.org/r/116662/#comment37144> Shouldn't Header and Page number be translated? - Thorsten Zachmann On March 9, 2014, 6:23 p.m., Denis Kuplyakov wrote: > > --- > This is

Re: Final release date?

2014-02-28 Thread Thorsten Zachmann
On Thursday, February 27, 2014 10:17:09 PM Dmitry Kazakov wrote: > Maintainers, ping! Are we releasing next Wednesday? :) > +1 Thorsten ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 115115: Fix for bug #327110 - Crash when trying to insert notes

2014-01-19 Thread Thorsten Zachmann
> On Jan. 19, 2014, 6:12 a.m., Thorsten Zachmann wrote: > > Nice patch please commit. Cool to see you around again. > > Fredy Yanardi wrote: > Thanks for reviewing, shall I commit it to 2.8 branch as well? Yes p

Re: Review Request 115109: _isnan is present only in MSVC's , for MinGW we still use std::isnan

2014-01-18 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115109/#review47665 --- Ship it! Ship It! - Thorsten Zachmann On Jan. 19, 2014, 3

Re: Review Request 115115: Fix for bug #327110 - Crash when trying to insert notes

2014-01-18 Thread Thorsten Zachmann
again. - Thorsten Zachmann On Jan. 19, 2014, 3:58 a.m., Fredy Yanardi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 114435: Turn off anti-aliasing when painting Karbon page rect / margins

2013-12-13 Thread Thorsten Zachmann
ttp://git.reviewboard.kde.org/r/114435/#comment32614> How about just removing the line instead of setting it to false. - Thorsten Zachmann On Dec. 13, 2013, 1:49 p.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 110821: Pasting of text when text tool is not active, and of images when default tool is not active. Etc

2013-11-30 Thread Thorsten Zachmann
ny possibility that cmd is not there? From looking at the code I think that is not possible as it was created above and therefor the if/else can be removed and only keep the content between the if - Thorsten Zachmann On Nov. 19, 2013, 5:19

Re: Review Request 111914: Add support for annotations, a.k.a. notes, to Words and Author

2013-11-07 Thread Thorsten Zachmann
annotation shape - Undo the adding (the shape is still shown) - do some text editing - Then add text to the annotation shape -> crash - Thorsten Zachmann On Nov. 6, 2013, 6:16 p.m., Inge Wallin wrote: > > --- > This is an a

Re: Review Request 112405: Added three protected methods to KoCreatePathTool

2013-09-01 Thread Thorsten Zachmann
ttp://git.reviewboard.kde.org/r/112405/#comment28827> Adding that is fine. Still it makes sense to move it to the if as in case d->shape is 0 the call can be avoided :-) - Thorsten Zachmann On Aug. 31, 2013, 3:52 p.m., Dmitry Kaza

Re: Review Request 112405: Added three protected methods to KoCreatePathTool

2013-08-31 Thread Thorsten Zachmann
h can be caused if there is no shape. - Thorsten Zachmann On Aug. 31, 2013, 3:52 p.m., Dmitry Kazakov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.

Re: Fwd: Application duplicated

2013-08-29 Thread Thorsten Zachmann
On Wednesday, August 28, 2013 10:22:12 PM Jaroslaw Staniek wrote: > Hi, Ideas whether this SoK app is Calligra-related and if it is, is > there any Calligra mentor willing to take it? > SoK mentor app deadline is tomorrow... > The student was in contact with me but I missed the deadline as I did n

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-22 Thread Thorsten Zachmann
> On Aug. 21, 2013, 5:51 a.m., Thorsten Zachmann wrote: > > libs/widgets/KoStrokeConfigWidget.cpp, lines 395-396 > > <http://git.reviewboard.kde.org/r/111747/diff/3/?file=175440#file175440line395> > > > > Who is going to delete the stroke that is emitted he

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-21 Thread Thorsten Zachmann
> On Aug. 21, 2013, 5:51 a.m., Thorsten Zachmann wrote: > > libs/basicflakes/tools/KoCreatePathTool.cpp, line 415 > > <http://git.reviewboard.kde.org/r/111747/diff/3/?file=175416#file175416line415> > > > > The activate is never called again. Is this correct?

Re: Review Request 111747: stage uses modebox, modebox capable of horizontal mode, various fixes

2013-08-20 Thread Thorsten Zachmann
Moved into one method libs/widgets/KoStrokeConfigWidget.cpp <http://git.reviewboard.kde.org/r/111747/#comment28291> Who is going to delete the stroke that is emitted here? Looks like a memory leak to me. - Thorsten Zachmann On July 30

Re: Review Request 112126: Remove warning about QVector resizing, optimize

2013-08-18 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112126/#review38093 --- Ship it! Ship It! - Thorsten Zachmann On Aug. 16, 2013, 8

Re: Review Request 111773: Add api for writing ODF that is generated from the ODF RNG file

2013-08-02 Thread Thorsten Zachmann
kde.org/r/111773/#comment27105> Is this always called with a cell? Otherwise the test should be back. - Thorsten Zachmann On Aug. 2, 2013, 11:59 p.m., Jos van den Oever wrote: > >

Re: Review Request 111773: Add api for writing ODF that is generated from the ODF RNG file

2013-07-28 Thread Thorsten Zachmann
memory usage for the writing out of odf? I would be very interested to see how it performs there. - Thorsten Zachmann On July 28, 2013, 9:47 p.m., Jos van den Oever wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 111615: Wrap KoShapeBackground in QSharedPointer

2013-07-28 Thread Thorsten Zachmann
oPatternBackground(imageCollection)); words/part/KWPageStyle.cpp <http://git.reviewboard.kde.org/r/111615/#comment27087> I'm not sure here but shouldn't this call d->fullPageBackground.clear()? - Thorsten Zachmann On July 28, 2

Re: Review Request 109887: Create a stream reader better suited for ODF than QXmlStreamReader

2013-07-28 Thread Thorsten Zachmann
On Saturday, July 27, 2013 03:07:27 PM Inge Wallin wrote: > On Saturday, July 27, 2013 05:56:23 Thorsten Zachmann wrote: > > Hello Inge, > > > > On Friday, July 26, 2013 07:16:54 PM Inge Wallin wrote: > > > ---

Re: Review Request 111615: Wrap KoShapeBackground in QPointer

2013-07-26 Thread Thorsten Zachmann
kde.org/r/111615/#comment26983> Using a QObject for all KoShapeBackgrounds is quite a very big overhead and also the first place why we did not use it - Thorsten Zachmann On July 20, 2013, 12:11 p.m., Boudewijn Rempt wrote: > > ---

Re: Review Request 109887: Create a stream reader better suited for ODF than QXmlStreamReader

2013-07-26 Thread Thorsten Zachmann
Hello Inge, On Friday, July 26, 2013 07:16:54 PM Inge Wallin wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109887/ > --- >

Re: Review Request 111044: Implement borders for shapes

2013-06-29 Thread Thorsten Zachmann
> On June 29, 2013, 3:43 a.m., Thorsten Zachmann wrote: > > libs/odf/KoBorder.cpp, lines 1067-1068 > > <http://git.reviewboard.kde.org/r/111044/diff/2/?file=165059#file165059line1067> > > > > This seems to miss handling cases there only the specialBorderSt

Re: Review Request 111305: "ko"-prefix installed, but so far namespace-less libs: msooxml, odfreader, vectorimage, textlayout

2013-06-28 Thread Thorsten Zachmann
? - Thorsten Zachmann On June 29, 2013, 12:40 a.m., Friedrich W. H. Kossebau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 111044: Implement borders for shapes

2013-06-28 Thread Thorsten Zachmann
et the value? libs/odf/KoBorder.cpp <http://git.reviewboard.kde.org/r/111044/#comment25840> This seems to miss handling cases there only the specialBorderString is set. - Thorsten Zachmann On June 22, 2013, 6:28 a.m.,

Re: Parametric QML-Shapes, Filetype

2013-06-19 Thread Thorsten Zachmann
On Monday 17 June 2013 00:21:12 David Lanzendörfer wrote: > Hi Folks > I was thinking about adding the feature for QML specification of parametric > shapes into calligra flow. > The only problem is that we would need to put the support for this into any > other application processing ODG files as w

Re: Review Request 111044: Implement borders for shapes

2013-06-19 Thread Thorsten Zachmann
please let me know and I will forward them to you. - Thorsten Zachmann On June 15, 2013, 6:35 p.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 110928: Always save the position of a shape

2013-06-10 Thread Thorsten Zachmann
; looks wrong to me. > > Inge Wallin wrote: > That's right, of course. I solved the problem but I introduced a new > one; good catch. Not saving 0,0 is a problem when it is asked to save the > position either by adding OdfPosition or OdfTransformation to the flags, not > if ne

Re: Review Request 110928: Always save the position of a shape

2013-06-10 Thread Thorsten Zachmann
> On June 10, 2013, 12:30 p.m., C. Boemann wrote: > > I think this is wrong. We shouldn't save position unless asked to (by > > setting the OdfPosition flag) > > > > I'm not even sure why not saving 0,0 is wrong? But the way you solve it > > looks wrong to me. > > Inge Wallin wrote: > Tha

Re: Question about loading and default list/bib/ToC styles

2013-05-27 Thread Thorsten Zachmann
On Monday 27 May 2013 21:19:56 Elvis Stansvik wrote: > Hi all, > > Currently trying to track down a bug and realized I'm a little unsure about > something. > > The style manager creates a bunch of default list/bibliography/ToC styles > upon construction. What should we do if, during loading, we e

Re: Review Request 110506: Ignore application of default styles in DockerStylesComboModel

2013-05-18 Thread Thorsten Zachmann
t it surely does not harm either. - Thorsten Zachmann On May 18, 2013, 3:39 p.m., Elvis Stansvik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.revie

Re: Review Request 110507: Create a second ODF library for classes not used in any application

2013-05-18 Thread Thorsten Zachmann
includes should use <> as the file is no longer in the same directory. - Thorsten Zachmann On May 18, 2013, 3:25 p.m., Inge Wallin wrote: > > --- > This is an autom

Re: Purpose and scope of libs/odf

2013-05-17 Thread Thorsten Zachmann
Hello > emphasized: > > In libs odf we > > should only have that what we are need for the apps and is very useful to > > them. > > Ok, this is a valid scope. The reason I started the work I'm currently > doing (aside from the docx filter) is because there are several sets of > named styles that

Re: Purpose and scope of libs/odf

2013-05-16 Thread Thorsten Zachmann
On Thursday 16 May 2013 18:51:52 Inge Wallin wrote: > * Objects that represent parts of an ODF document that are used only in > filters. Applications have more sophisticated implementations that allow > editing and with more efficient memory management: KoCell, KoColumn, ... This classes also do

Re: Review Request 110408: Improve the styles handling in libs/odf/styles

2013-05-12 Thread Thorsten Zachmann
operties.cpp <http://git.reviewboard.kde.org/r/110408/#comment24094> The dummy can be removed if the class is empty. - Thorsten Zachmann On May 12, 2013, 4:22 p.m., Inge Wallin wrote: > > --- > This is an automatically

Re: Review Request 110408: Improve the styles handling in libs/odf/styles

2013-05-12 Thread Thorsten Zachmann
bs as long it is not needed there. - Thorsten Zachmann On May 12, 2013, 4:22 p.m., Inge Wallin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Dot article about the calligra sprint in Essen / Bangalore

2013-04-30 Thread Thorsten Zachmann
egetarian to pretty meaty. The master chefs > were Dan Jensen, Arjen Hiemstra and Thorsten Zachmann. Dan was not at the sprint :-) Otherwise the article looks good to me. Thorsten ___ calligra-devel mailing list calligra-devel@kde.org https://mail.

Re: Review Request 109980: Load styles into a new, more generic style manager

2013-04-17 Thread Thorsten Zachmann
On Tuesday 16 April 2013 21:50:30 Inge Wallin wrote: > Actually this patch is -- beside being a bit of a rush job because we need > to get a working docx filter in less than 2 weeks -- the first patch in my > suggested plan to fix these issues. And this plan was discussed on this > mailing list if

Re: Review Request 109994: New implementation for handling formulas

2013-04-13 Thread Thorsten Zachmann
t m_isLastCommandRedo = false;? plugins/staging/formulashape-2g/FormulaShape.cpp <http://git.reviewboard.kde.org/r/109994/#comment23030> is there a reason m_document and m_cursor are not deleted here? - Thorsten Zachmann On April 13, 2013,

Re: Review Request 109980: Load styles into a new, more generic style manager

2013-04-13 Thread Thorsten Zachmann
Hello, > Here is step 2 in the plan to create a docx export filter. > > It contains code to load styles into a decently generic style manager. The > main use of this version will be as a much faster alternative to > KoOdfStylesReader that forces you to reparse the XML of all styles that you > wan

Re: Review Request 109887: Create a stream reader better suited for ODF than QXmlStreamReader

2013-04-06 Thread Thorsten Zachmann
be tested for speed to see if it does not impact performance of the way we use stuff. Also I'm not confident that mixing here helps. With later versions of the ODF spec such elements that are not sound might increase also. - Thorsten Zachmann On April 6, 2013, 3:56 p.m., Inge Wallin

Re: Review Request 109877: Make calligra compile with clang

2013-04-05 Thread Thorsten Zachmann
for the sake of staying in the same toolkit and not start mixing the different stuff when possible and QVector is just fine here. - Thorsten Zachmann On April 5, 2013, 5:41 p.m., Fabian Kosmale wrote: > > --- > This is an auto

Re: Review Request 109746: Expansion of the References section by adding features to insert hyperlinks, bookmarks and links to bookmarks.

2013-04-01 Thread Thorsten Zachmann
ewboard.kde.org/r/109746/#comment22512> I think this should be change to a QList. - Thorsten Zachmann On March 31, 2013, 4:17 a.m., Aman Madaan wrote: > > --- > This

Re: Rename Coffice?

2013-03-28 Thread Thorsten Zachmann
Hello Sebastian, On Thursday 28 March 2013 18:10:35 Sebastian Sauer wrote: > * Or alternatively port Calligra to Qt5. boud is working on that and in the same time trying to reduce the kde dependencies where needed and remove the usage of kparts. Maybe you can join forces. Thorsten

Re: Review Request 109651: Refactor style manager

2013-03-24 Thread Thorsten Zachmann
--- Tested modification without saving. Tested applying. Tested Ok. Tested Canceling Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request 109651: Refactor style manager

2013-03-24 Thread Thorsten Zachmann
not be related to your changes. 2 is unrelated to my fix. - Thorsten ------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109651/#review29793 ---

Re: Review Request 109700: Make KoProgressProxy (re)usuable without KoMainWindow

2013-03-24 Thread Thorsten Zachmann
comment before you commit. - Thorsten Zachmann On March 25, 2013, 4:47 a.m., Sebastian Sauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request 109651: Refactor style manager

2013-03-23 Thread Thorsten Zachmann
-CREATION Diff: http://git.reviewboard.kde.org/r/109651/diff/ Testing --- Tested modification without saving. Tested applying. Tested Ok. Tested Canceling Thanks, Thorsten Zachmann ___ calligra-devel mailing list calligra-devel@kde.org https

Review Request 109651: Refactor style manager

2013-03-21 Thread Thorsten Zachmann
/StylesSortFilterProxyModel.h PRE-CREATION plugins/textshape/dialogs/StylesSortFilterProxyModel.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109651/diff/ Testing --- Tested modification without saving. Tested applying. Tested Ok. Tested Canceling Thanks, Thorsten Zachmann

Re: [calligra] plugins: disable video shape, it broke the build

2013-03-12 Thread Thorsten Zachmann
On Tuesday 12 March 2013 13:10:48 Boudewijn Rempt wrote: > On Tue, 12 Mar 2013, Gopalakrishna Bhat wrote: > > Can you please post the error you are getting. It is working fine here. > > It's on the build > server: http://build.kde.org/job/calligra_master_win32/341/, check > > http://build.kde.org

Re: Review Request 109370: Support same style names in different families

2013-03-09 Thread Thorsten Zachmann
les.h 8041441 libs/odf/KoGenStyles.cpp 7a92453 libs/odf/tests/TestKoGenStyles.cpp 5818091 Diff: http://git.reviewboard.kde.org/r/109370/diff/ Testing --- cstester and roundtrip testing Thanks, Thorsten Zachmann ___ calligra-devel mailing

Re: Review Request 109370: Support same style names in different families

2013-03-09 Thread Thorsten Zachmann
le where this is not the case for investigation. - Thorsten --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109370/#review28839 --- On March 9, 20

  1   2   3   4   5   6   7   >