----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122266/#review74799 -----------------------------------------------------------
I pointed out some style issues. However the rest of the code looks good and can go in if no issues with cstester are found. words/part/KWRootAreaProviderBase.h <https://git.reviewboard.kde.org/r/122266/#comment51839> There is also a root area provider outside of words. And I guess this handles words specific stuff that can't be done in the generic one. words/part/KWRootAreaProviderBase.h <https://git.reviewboard.kde.org/r/122266/#comment51840> Indent wrong words/part/KWRootAreaProviderBase.cpp <https://git.reviewboard.kde.org/r/122266/#comment51841> There should be { } around the return words/part/KWRootAreaProviderBase.cpp <https://git.reviewboard.kde.org/r/122266/#comment51842> There should be {} even around single line if statements words/part/KWRootAreaProviderTextBox.cpp <https://git.reviewboard.kde.org/r/122266/#comment51844> There should be a {} aound single line of if. words/part/KWRootAreaProviderTextBox.cpp <https://git.reviewboard.kde.org/r/122266/#comment51843> The opening { should be in the line of the if words/part/KWRootAreaProviderTextBox.cpp <https://git.reviewboard.kde.org/r/122266/#comment51845> There should be {} around single line while words/part/KWRootAreaProviderTextBox.cpp <https://git.reviewboard.kde.org/r/122266/#comment51846> There should be {} around single line if. - Thorsten Zachmann On Jan. 26, 2015, 11:17 p.m., Camilla Boemann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122266/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2015, 11:17 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > split kwrootareaprovider in 3 classes for better overview and solving text > flwing between textboxes > > > Diffs > ----- > > words/part/CMakeLists.txt 386431e > words/part/KWRootAreaProvider.h 54deaf3 > words/part/KWRootAreaProvider.cpp d26f519 > words/part/KWRootAreaProviderBase.h PRE-CREATION > words/part/KWRootAreaProviderBase.cpp PRE-CREATION > words/part/KWRootAreaProviderTextBox.h PRE-CREATION > words/part/KWRootAreaProviderTextBox.cpp PRE-CREATION > words/part/frames/KWFrame.cpp f88f902 > words/part/frames/KWTextFrameSet.h 9106758 > words/part/frames/KWTextFrameSet.cpp c8ccdb9 > > Diff: https://git.reviewboard.kde.org/r/122266/diff/ > > > Testing > ------- > > ran cstester and did some manual testing, but should eally do it again > > > Thanks, > > Camilla Boemann > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
