----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125510/#review86339 -----------------------------------------------------------
Ship it! Patch looks good. Please commit. - Thorsten Zachmann On Oct. 3, 2015, 6:15 p.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125510/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2015, 6:15 p.m.) > > > Review request for Calligra and Thorsten Zachmann. > > > Repository: calligra > > > Description > ------- > > Add KPrShapeAnimations::dump() for debugging the animation tree. > > > Diffs > ----- > > stage/part/KPrShapeAnimations.h c00af6df1fc94e69b4924877aa76de52ac750e1c > stage/part/KPrShapeAnimations.cpp a7e51724f1abec256842832bf961679cba4cc7b5 > > Diff: https://git.reviewboard.kde.org/r/125510/diff/ > > > Testing > ------- > > This explained to me why swapping doesn't do what I expect: it swaps leaves > in a tree structure, while to the user this is presented as a list so as a > user I would expect it to swap list elements - including the fact that an > item is the beginning of a step. Seems tricky to implement though.... > > > Thanks, > > David Faure > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
