----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110408/#review32397 -----------------------------------------------------------
libs/odf/styles/KoOdfGraphicProperties.h <http://git.reviewboard.kde.org/r/110408/#comment24091> This should not have an additional Private in my opinion but should use the same technique used by e.g. KoShape and its private. libs/odf/styles/KoOdfGraphicProperties.cpp <http://git.reviewboard.kde.org/r/110408/#comment24092> I think we should not commit unfinished code. libs/odf/styles/KoOdfStyleProperties.h <http://git.reviewboard.kde.org/r/110408/#comment24093> This should not put directly in the file as it pollutes the global namespace. You can define them on top of the cpp file. libs/odf/styles/KoOdfTextProperties.cpp <http://git.reviewboard.kde.org/r/110408/#comment24094> The dummy can be removed if the class is empty. - Thorsten Zachmann On May 12, 2013, 4:22 p.m., Inge Wallin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110408/ > ----------------------------------------------------------- > > (Updated May 12, 2013, 4:22 p.m.) > > > Review request for Calligra and Matus Uzak. > > > Description > ------- > > This is the second step in the quest to improve styles handling in Calligra. > This patch introduces text-properties, paragraph-properties and > graphic-properties in the styles, which means that more specific information > than only attributes. The style:text-properties element don't have any child > elements but paragraph-properties do (background-image, drop-cap and > tab-stops) and also graphic-properties. > > Not everything is implemented yet but I wanted to support > style:background-image in libs/odf for the styles that are already in use > everywhere before implementing it here. > > In the short term, this is important for the docx filter, and to save back > named styles in Karbon and styles with family=graphic in all applications. > > > Diffs > ----- > > libs/odf/CMakeLists.txt b3940c1 > libs/odf/styles/KoOdfGraphicProperties.h PRE-CREATION > libs/odf/styles/KoOdfGraphicProperties.cpp PRE-CREATION > libs/odf/styles/KoOdfParagraphProperties.h PRE-CREATION > libs/odf/styles/KoOdfParagraphProperties.cpp PRE-CREATION > libs/odf/styles/KoOdfStyle.cpp aac9ea2 > libs/odf/styles/KoOdfStyleProperties.h 9453989 > libs/odf/styles/KoOdfStyleProperties.cpp 7a34bf9 > libs/odf/styles/KoOdfTextProperties.h PRE-CREATION > libs/odf/styles/KoOdfTextProperties.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/110408/diff/ > > > Testing > ------- > > > Thanks, > > Inge Wallin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
