----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117626/#review56043 -----------------------------------------------------------
filters/libodf2/KoOdfStyleProperties.h <https://git.reviewboard.kde.org/r/117626/#comment39104> How about passing the argument as a const & instead of a pointer. If you pass a pointer you should check it for null which is not done. filters/words/docx/export/DocxExport.h <https://git.reviewboard.kde.org/r/117626/#comment39105> From API consistency should the parent not be the last parameter in the argument list. filters/words/docx/export/DocxExport.cpp <https://git.reviewboard.kde.org/r/117626/#comment39106> Do these guys realy have a copyright on the code? filters/words/docx/export/DocxExport.cpp <https://git.reviewboard.kde.org/r/117626/#comment39107> we already have 2014 filters/words/docx/export/DocxFile.h <https://git.reviewboard.kde.org/r/117626/#comment39108> We already have 2014 filters/words/docx/export/DocxFile.cpp <https://git.reviewboard.kde.org/r/117626/#comment39109> We have 2014 already filters/words/docx/export/DocxStyleHelper.cpp <https://git.reviewboard.kde.org/r/117626/#comment39110> This code is duplicated below and it can be refactored to be in a method to avoid code duplication filters/words/docx/export/OpcRelSet.h <https://git.reviewboard.kde.org/r/117626/#comment39111> This function seems to be not implemented. libs/odf/KoDirectoryStore.h <https://git.reviewboard.kde.org/r/117626/#comment39112> I think it would be better to add a function to set if you want to write the mimetype instead of adding it to every constructor. Much less code change and only need to be called when needed. libs/odf/KoEncryptedStore.cpp <https://git.reviewboard.kde.org/r/117626/#comment39113> the unsetting/setting of the compression does not need to be done when no mimetype file is written - Thorsten Zachmann On April 18, 2014, 9:38 a.m., Inge Wallin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117626/ > ----------------------------------------------------------- > > (Updated April 18, 2014, 9:38 a.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > This patch implements the first simple version of a docx export filter. It > has support for simple character formatting and paragraph formatting, > including named styles. It can also distinguish between headers and normal > paragraphs [This turned out not to be true when I look at the code in the RR > now. But it will be before it's merged. We will concentrate on this now]. > Other than that it's an unwritten page. A special thanks to Lassi Nieminen > who helped me with converting the styles. > > The patch itself is very straightforward and mostly self contained in the > filters/words/docx subdirectory. It builds on my previous work with > libodfreader and libodf2, which are both in filters/. The only problem was > that the KoZipStore and KoEncryptedStore backends create a file called > "mimetype" automatically when a KoStore is created in write mode. I tried to > work around this with as little impact as possible to the code in libs/odf > and with full source compatibility with the previous API. If you think there > is a better way to solve this problem than the one I implemented, then please > tell me. > > > Diffs > ----- > > CMakeLists.txt 78421c5 > filters/libodf2/KoOdfStyle.h 558ade9 > filters/libodf2/KoOdfStyle.cpp 2b4eb95 > filters/libodf2/KoOdfStyleManager.h 3761d38 > filters/libodf2/KoOdfStyleManager.cpp a7f18a2 > filters/libodf2/KoOdfStyleProperties.h 1bfbb5c > filters/libodf2/KoOdfStyleProperties.cpp 186e971 > filters/libodfreader/OdtReader.h 64e0584 > filters/libodfreader/OdtReader.cpp 6fa8ce6 > filters/words/docx/CMakeLists.txt f38a2bb > filters/words/docx/export/CMakeLists.txt PRE-CREATION > filters/words/docx/export/DocxExport.h PRE-CREATION > filters/words/docx/export/DocxExport.cpp PRE-CREATION > filters/words/docx/export/DocxFile.h PRE-CREATION > filters/words/docx/export/DocxFile.cpp PRE-CREATION > filters/words/docx/export/DocxStyleHelper.h PRE-CREATION > filters/words/docx/export/DocxStyleHelper.cpp PRE-CREATION > filters/words/docx/export/DocxStyleWriter.h PRE-CREATION > filters/words/docx/export/DocxStyleWriter.cpp PRE-CREATION > filters/words/docx/export/FileCollector.h PRE-CREATION > filters/words/docx/export/FileCollector.cpp PRE-CREATION > filters/words/docx/export/OdfReaderDocxContext.h PRE-CREATION > filters/words/docx/export/OdfReaderDocxContext.cpp PRE-CREATION > filters/words/docx/export/OdfTextReaderDocxBackend.h PRE-CREATION > filters/words/docx/export/OdfTextReaderDocxBackend.cpp PRE-CREATION > filters/words/docx/export/OdtReaderDocxBackend.h PRE-CREATION > filters/words/docx/export/OdtReaderDocxBackend.cpp PRE-CREATION > filters/words/docx/export/OpcContentTypes.h PRE-CREATION > filters/words/docx/export/OpcContentTypes.cpp PRE-CREATION > filters/words/docx/export/OpcRelSet.h PRE-CREATION > filters/words/docx/export/OpcRelSet.cpp PRE-CREATION > filters/words/docx/export/OpcRelSetManager.h PRE-CREATION > filters/words/docx/export/OpcRelSetManager.cpp PRE-CREATION > filters/words/docx/export/README PRE-CREATION > filters/words/docx/export/UnitConversions.h PRE-CREATION > filters/words/docx/export/UnitConversions.cpp PRE-CREATION > filters/words/docx/export/words_docx_export.desktop PRE-CREATION > libs/odf/KoDirectoryStore.h 19c059d > libs/odf/KoDirectoryStore.cpp c893d47 > libs/odf/KoEncryptedStore.h 0edd892 > libs/odf/KoEncryptedStore.cpp 315df1a > libs/odf/KoStore.h dadecd1 > libs/odf/KoStore.cpp fd42378 > libs/odf/KoStore_p.h 2e518c1 > libs/odf/KoTarStore.h d99f09b > libs/odf/KoTarStore.cpp 6829f34 > libs/odf/KoZipStore.h 90ffcb0 > libs/odf/KoZipStore.cpp 4235134 > > Diff: https://git.reviewboard.kde.org/r/117626/diff/ > > > Testing > ------- > > Testing with a number of odt files. Lassi did all the testing involving MS > Office since I don't have that. > > > Thanks, > > Inge Wallin > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
