----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116662/#review52589 -----------------------------------------------------------
words/part/dockers/KWNavigationDocker.h <https://git.reviewboard.kde.org/r/116662/#comment37136> No need to include in the header. Please use a forward declaration like: class KWNavigationWidget and include in the cpp file. words/part/dockers/KWNavigationDocker.h <https://git.reviewboard.kde.org/r/116662/#comment37135> Please move to its own class. words/part/dockers/KWNavigationDocker.cpp <https://git.reviewboard.kde.org/r/116662/#comment37137> This would be better put in the initialisation list of the constructor. words/part/dockers/KWNavigationDocker.cpp <https://git.reviewboard.kde.org/r/116662/#comment37138> This would be better put to the initialisation list of the constructor words/part/dockers/KWNavigationWidget.cpp <https://git.reviewboard.kde.org/r/116662/#comment37143> Is there still something missing? If not please remove the TODO words/part/dockers/KWNavigationWidget.cpp <https://git.reviewboard.kde.org/r/116662/#comment37144> Shouldn't Header and Page number be translated? - Thorsten Zachmann On March 9, 2014, 6:23 p.m., Denis Kuplyakov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116662/ > ----------------------------------------------------------- > > (Updated March 9, 2014, 6:23 p.m.) > > > Review request for Calligra, Inge Wallin and Dan Leinir Turthra Jensen. > > > Repository: calligra > > > Description > ------- > > That's the navigator docker for Words. It allow to quickly navigate through > document by jumping to sections headers. > Navigator looks through all paragraphs with outline property, and stores them > in QTreeView allowing fast jump with single click. > > I want some response about UI: > 1) maybe make the rows bigger? > > and about the implementation: > 2) how can we track structure changes more effective to avoid complete > rebuilding of tree? > 3) view is flickering when updating.. > > > Diffs > ----- > > words/part/CMakeLists.txt e6e39e8 > words/part/KWFactory.cpp 14dfbed > words/part/dockers/KWNavigationDocker.h PRE-CREATION > words/part/dockers/KWNavigationDocker.cpp PRE-CREATION > words/part/dockers/KWNavigationWidget.h PRE-CREATION > words/part/dockers/KWNavigationWidget.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/116662/diff/ > > > Testing > ------- > > Have tested it on document, containing 3 pages with many headers of different > levels. > > > File Attachments > ---------------- > > Test file > > https://git.reviewboard.kde.org/media/uploaded/files/2014/03/08/4147a7ee-bb9b-4ff9-b809-fba7c2eb1b16__test.odt > > > Thanks, > > Denis Kuplyakov > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
