----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109877/#review30537 -----------------------------------------------------------
I think we should go with QVector instead of std::vector just for the sake of staying in the same toolkit and not start mixing the different stuff when possible and QVector is just fine here. - Thorsten Zachmann On April 5, 2013, 5:41 p.m., Fabian Kosmale wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109877/ > ----------------------------------------------------------- > > (Updated April 5, 2013, 5:41 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Clang doesn't support variable length arrays for non POD types (see > http://clang.llvm.org/compatibility.html#vla). I chose std::vector instead of > QVector, because the later has AFAIK a greater impact on used memory and we > don't need its additional features. > > > Diffs > ----- > > plugins/staging/pivottables/pivotmain.cpp > 6045618bfcb64941ca9a82b8be072e9786c222dc > > Diff: http://git.reviewboard.kde.org/r/109877/diff/ > > > Testing > ------- > > It now compiles and the applications still run. However I don't know how to > test the functionality (Pivo) of the file I've changed. > > > Thanks, > > Fabian Kosmale > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
