> On March 24, 2013, 12:12 p.m., Elvis Stansvik wrote: > > I've now tested the branch a bit. No crashes anymore, but I noticed two > > things: > > > > 1) Try this in the Style Manager: > > > > 1) Click "New" in the "Paragraph" tab. > > (A new paragraph style called "New Style" is created) > > 2) Click "New" in the "Character" tab. > > (A new character style called "New Style" is created) > > 3) Click the "Paragraph" tab. > > 4) A dialog pops up saying the name "New Style" is already used. > > 5) Click OK to confirm the dialog. > > 6) You're brought to the "Paragraph" tab. > > 7) The dialog pops up again. > > 8) ---> Loop > > > > 2) When adding a new style in the Style Manager, it shows up correctly in > > the styles combo under "Text editing". But after changing a style and > > hitting "Apply" in the Style Manager, the look is not updated in the combo. > > This may not be related to your changes.
2 is unrelated to my fix. - Thorsten ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109651/#review29793 ----------------------------------------------------------- On March 24, 2013, 6:35 a.m., Thorsten Zachmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109651/ > ----------------------------------------------------------- > > (Updated March 24, 2013, 6:35 a.m.) > > > Review request for Calligra and Pierre Stirnweiss. > > > Description > ------- > > This patch tries to fix the problems/crashes which happen in the style > manager. > > To get the simple crash open the default document and click on the edit > button of the None (character style) > > The patch uses a different model for the style manager and temporary styles > that get modified to only apply the changes once the user applies them. > The model changes the internal pointer to the temporary files once they are > selected and when applied resets to the original ones. > However the styles preview in the styles manager list is updated immediately. > The patch simplifies the handling quite a bit. > > I did not know that Pierre was also working on that so I publish it now so we > have something we can discuss. > > If you like this I would like to backport it to 2.6 as it fixes quite some > grave bugs compared to what we have now. > > > Diffs > ----- > > libs/kotext/styles/KoCharacterStyle.h 2fdde12 > libs/textlayout/KoStyleThumbnailer.cpp 436b243 > plugins/textshape/CMakeLists.txt 084628c > plugins/textshape/dialogs/CharacterGeneral.h e6d99db > plugins/textshape/dialogs/CharacterGeneral.cpp d3eead6 > plugins/textshape/dialogs/ParagraphGeneral.h 1a78376 > plugins/textshape/dialogs/ParagraphGeneral.cpp ad30369 > plugins/textshape/dialogs/StyleManager.h dec3b6b > plugins/textshape/dialogs/StyleManager.cpp 9c82c11 > plugins/textshape/dialogs/StylesManagerModel.h PRE-CREATION > plugins/textshape/dialogs/StylesManagerModel.cpp PRE-CREATION > plugins/textshape/dialogs/StylesSortFilterProxyModel.h PRE-CREATION > plugins/textshape/dialogs/StylesSortFilterProxyModel.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/109651/diff/ > > > Testing > ------- > > Tested modification without saving. > Tested applying. > Tested Ok. > Tested Canceling > > > Thanks, > > Thorsten Zachmann > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
