----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122867/#review77243 -----------------------------------------------------------
Ship it! The patch looks good to me. - Thorsten Zachmann On March 9, 2015, 11:52 a.m., Robert Mathias Marmorstein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122867/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 11:52 a.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > The strstream class has been deprecated for some time in favor of the sstream > classes. This patch replaces strstream with sstreams. > > > Diffs > ----- > > filters/sheets/qpro/libqpro/src/formula.cc c5d6021 > filters/sheets/qpro/libqpro/src/record.cc bde5e7d > filters/sheets/qpro/libqpro/src/stream.cc 4126aee > > Diff: https://git.reviewboard.kde.org/r/122867/diff/ > > > Testing > ------- > > After the change calligra compiles and passes the same unit tests as before. > Unfortunately, I don't have any qpro files lying around to test this on. > > > Thanks, > > Robert Mathias Marmorstein > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
