rdblue commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2047470113
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -369,4 +390,28 @@ static List<String> withStatsColumns(Collection<String>
columns) {
return projectColumns;
}
}
+
+ private static <F extends ContentFile<F>> Function<ManifestEntry<F>,
ManifestEntry<F>> idAssigner(
+ Long firstRowId) {
+ if (firstRowId != null) {
Review Comment:
It ends up being multiple things. One case is when the manifest itself
doesn't have a `first_row_id` because it was in an upgraded snapshot. Another
is when this class is reading a delete manifest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
