RussellSpitzer commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2047762613


##########
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##########
@@ -359,12 +359,40 @@ public void testReplace() {
 
     
table.newRewrite().deleteFile(filePart1).deleteFile(filePart2).addFile(fileCompacted).commit();
 
-    // Rewrites are currently just treated as appends. In the future we could 
treat these as no-ops
+    // rewrites produce new manifests without first-row-id or any information 
about how many rows

Review Comment:
   ```suggestion
       // Rewrites produce new manifests without first-row-id or any 
information about how many rows
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to