rdblue commented on code in PR #12672: URL: https://github.com/apache/iceberg/pull/12672#discussion_r2047196271
########## core/src/main/java/org/apache/iceberg/InheritableMetadataFactory.java: ########## @@ -41,6 +41,7 @@ static InheritableMetadata fromManifest(ManifestFile manifest) { manifest.path()); } + /** Returns {@link InheritableMetadata} for rewriting a manifest before it is committed. */ Review Comment: I'm no longer changing this class, but I think it's reasonable to keep the additional javadoc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org