RussellSpitzer commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2047766671
##########
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##########
@@ -359,12 +359,40 @@ public void testReplace() {
table.newRewrite().deleteFile(filePart1).deleteFile(filePart2).addFile(fileCompacted).commit();
- // Rewrites are currently just treated as appends. In the future we could
treat these as no-ops
+ // rewrites produce new manifests without first-row-id or any information
about how many rows
+ // are new. without tracking a new metric for a manifest (e.g.,
assigned-rows) or assuming that
+ // rewrites do not assign any new IDs, replace will allocate ranges like
normal writes.
assertThat(table.currentSnapshot().firstRowId()).isEqualTo(60);
assertThat(table.currentSnapshot().addedRows()).isEqualTo(60);
assertThat(table.ops().current().nextRowId()).isEqualTo(120);
}
+ @TestTemplate
+ public void testRewrite() {
Review Comment:
Nit: testRewriteManifests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
