rdblue commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2040368273


##########
core/src/test/java/org/apache/iceberg/TestManifestReader.java:
##########
@@ -130,9 +130,6 @@ public void testDataFilePositions() throws IOException {
       long expectedPos = 0L;
       for (DataFile file : reader) {
         assertThat(file.pos()).as("Position should 
match").isEqualTo(expectedPos);
-        assertThat(((BaseFile) file).get(20))
-            .as("Position from field index should match")
-            .isEqualTo(expectedPos);

Review Comment:
   I removed this because the line above tests that `file.pos()` is correct. 
This assertion is incorrect because it expects the field order not to change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to