rdblue commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2040246626
##########
core/src/main/java/org/apache/iceberg/GenericManifestFile.java:
##########
@@ -128,8 +131,15 @@ public GenericManifestFile(Schema avroSchema) {
this.deletedRowsCount = deletedRowsCount;
this.partitions = partitions == null ? null : partitions.toArray(new
PartitionFieldSummary[0]);
this.keyMetadata = ByteBuffers.toByteArray(keyMetadata);
+ this.firstRowId = firstRowId;
}
+ /**
+ * GenericManifestFile constructor.
+ *
+ * @deprecated will be removed in 1.10.0; use {@link
ManifestWriter#toManifestFile()} instead.
+ */
+ @Deprecated
Review Comment:
This touches more files so I'll take care of it in a follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
