rdblue commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2047200882
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -369,4 +390,28 @@ static List<String> withStatsColumns(Collection<String>
columns) {
return projectColumns;
}
}
+
+ private static <F extends ContentFile<F>> Function<ManifestEntry<F>,
ManifestEntry<F>> idAssigner(
Review Comment:
Keeping state in `InheritableMetadata` doesn't work because it is reused
each time the reader produces an iterator. That causes incorrect row ID
assignment (caught by the tests I'm working on). Instead, I've introduced this
assigner function that is called where `InheritableMetadata` is used.
`InheritableMetadata` is used for constants, this is used for state-based ID
assignment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
