RussellSpitzer commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2047773423
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java:
##########
@@ -153,7 +155,10 @@ public void testUnpartitionedTable() throws Exception {
assertThat(expectedDataManifests).as("Should have 1 data
manifest").hasSize(1);
assertThat(expectedDeleteManifests).as("Should have 1 delete
manifest").hasSize(1);
- Schema entriesTableSchema = Spark3Util.loadIcebergTable(spark, tableName +
".entries").schema();
+ Schema entriesTableSchema =
+ TypeUtil.selectNot(
+ Spark3Util.loadIcebergTable(spark, tableName +
".entries").schema(),
+ Set.of(DataFile.FIRST_ROW_ID.fieldId()));
Review Comment:
May be worth adding a
```java
private Schema entriesTableSchema() {
return TypeUtil.selectNot(
Spark3Util.loadIcebergTable(spark, tableName +
".entries").schema(),
Set.of(DataFile.FIRST_ROW_ID.fieldId()));
}
```
To reduce the redundancy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
