RussellSpitzer commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2047400030
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -369,4 +390,28 @@ static List<String> withStatsColumns(Collection<String>
columns) {
return projectColumns;
}
}
+
+ private static <F extends ContentFile<F>> Function<ManifestEntry<F>,
ManifestEntry<F>> idAssigner(
+ Long firstRowId) {
+ if (firstRowId != null) {
Review Comment:
Just checking, this is protecting against delete manifests and data
manifests written before first-row-id is assignable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
