rdblue commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2036175237


##########
core/src/main/java/org/apache/iceberg/V3Metadata.java:
##########
@@ -140,6 +143,22 @@ private Object get(int pos) {
           return wrapped.partitions();
         case 14:
           return wrapped.keyMetadata();
+        case 15:
+          if (wrappedFirstRowId != null) {
+            // if first-row-id is assigned, ensure that it is valid

Review Comment:
   The purpose is to make sure that this isn't used to replace an already 
assigned `first-row-id`. In order to assign one by calling `wrap(file, 
firstRowId)`, the file must be a data file and the row id can't already be 
assigned.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to