rdblue commented on code in PR #12672:
URL: https://github.com/apache/iceberg/pull/12672#discussion_r2036194341
##########
core/src/test/java/org/apache/iceberg/rest/responses/TestLoadTableResponseParser.java:
##########
@@ -138,8 +137,8 @@ public void roundTripSerdeV1() {
}
@ParameterizedTest
- @ValueSource(ints = {2, MAX_FORMAT_VERSION})
- public void roundTripSerdeV2andHigher(int formatVersion) {
+ @ValueSource(ints = 3)
Review Comment:
I've used the approach above and standardized on
`@FieldSource("org.apache.iceberg.TestHelpers#ALL_VERSIONS")` with an
assumption that `formatVersion >= 3`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
