amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1765979097
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -153,6 +154,12 @@ void caseSensitive(boolean newCaseSensitive) {
void delete(F file) {
Preconditions.checkNotNull(file, "Cannot delete file: null");
invalidateFilteredCache();
+ if (file.manifestLocation() != null) {
+ deletedManifestPositions
+ .computeIfAbsent(file.manifestLocation(), key -> Sets.newHashSet())
+ .add(file.pos());
Review Comment:
I'm going to make this update to put 162 behind an else block if and
benchmark, I think it goes beyond memory usage we can avoid the unnecessary
file path and partition tracking completely. It's basically unnecessary work
when the referenced manifest is defined, and it probably has a performance cost
as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
